Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example data for RMF #1140

Closed

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Oct 18, 2024

Asana Task/Github Issue:

Description

  • First I added the file special-pages/messages/new-tab/types/rmf-message.json
    • this describes each message type in a format that suits Typescript
  • Then, to signal that this data can be pushed into the application, I created special-pages/messages/new-tab/rmf_onDataUpdate.subscribe.json
    • The naming of this file is used to document how the data will be sent from the native implementors
  • With these in place, I then ran npm run build from either folder (root or special-pages)
    • that updates the types file special-pages/types/new-tab.ts
  • Then, inside the component, I imported the type with
    @import { RMFMessage } from "../../../../types/new-tab"
    
  • Finally, I slightly tweaks the props of the component to have the message separate, to allow the action handlers to be passed in separately

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane mentioned this pull request Oct 18, 2024
8 tasks
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Oct 18, 2024

[Beta] Generated file diff

Time updated: Mon, 21 Oct 2024 11:55:06 GMT

Integration
    - integration/pages/new-tab/js/index.js

File has changed

Windows
    - windows/pages/new-tab/js/index.js

File has changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant