Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the rebase #1138

Conversation

shakyShane
Copy link
Contributor

Asana Task/Github Issue:

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

vkraucunas and others added 16 commits October 15, 2024 21:44
* update readme + fix package script

* Update README.md

---------

Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com>
Co-authored-by: Jonathan Kingston <jkingston@duckduckgo.com>
* ntp: stats feedback

* deps

* move esbuild dependency into special-pages

---------

Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com>
* Automation PR comment

* Make updating comment

* Move to envs

* Use files again as truncated

* Add beta flag
* Release debugging

* Make test release

* Add version back in and clean up

* Fix build paths

* Update types back

* Rename out file
* Remove checking out main

* Account for both branches existing or not
Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com>
Co-authored-by: Jonathan Kingston <jkingston@duckduckgo.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…to vkraucunas/ntp-remotemessagingframwork-fe
@shakyShane
Copy link
Contributor Author

shakyShane commented Oct 18, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Oct 18, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane marked this pull request as ready for review October 18, 2024 13:34
@shakyShane shakyShane requested a review from mgurgel as a code owner October 18, 2024 13:34
Copy link

github-actions bot commented Oct 18, 2024

[Beta] Generated file diff

Time updated: Fri, 18 Oct 2024 13:35:35 GMT

Integration
    - integration/pages/new-tab/js/index.js

File has changed

Windows
    - windows/pages/new-tab/js/index.js

File has changed

@shakyShane shakyShane mentioned this pull request Oct 18, 2024
8 tasks
@vkraucunas vkraucunas force-pushed the vkraucunas/ntp-remotemessagingframwork-fe branch from ac3c681 to 2f1d435 Compare October 19, 2024 03:55
@vkraucunas vkraucunas requested a review from a team as a code owner October 19, 2024 03:55
@shakyShane shakyShane closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants