Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: keyboard support for stats #1149

Merged
merged 2 commits into from
Oct 21, 2024
Merged

ntp: keyboard support for stats #1149

merged 2 commits into from
Oct 21, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Oct 21, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208590466011386/f

Description

  • back porting accessible keyboard support (from favorites branch)
  • co-locate test files (playwright has no issue finding them)

Testing Steps

ScreenFlow.mp4

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Oct 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 998dbf5
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67164a9b9b3425000903acb1
😎 Deploy Preview https://deploy-preview-1149--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane mentioned this pull request Oct 21, 2024
11 tasks
Copy link

github-actions bot commented Oct 21, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Oct 21, 2024

[Beta] Generated file diff

Time updated: Mon, 21 Oct 2024 12:36:43 GMT

Integration
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js
  • integration/pages/new-tab/locales/en/newtab.json

File has changed

Windows
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js
  • windows/pages/new-tab/locales/en/newtab.json

File has changed

@shakyShane shakyShane marked this pull request as ready for review October 21, 2024 12:27
@shakyShane shakyShane requested review from mgurgel and a team as code owners October 21, 2024 12:27
@shakyShane shakyShane changed the title ntp: keyboard support ntp: keyboard support for stats Oct 21, 2024
@shakyShane shakyShane force-pushed the stats_keyboard_support branch from 7623382 to 998dbf5 Compare October 21, 2024 12:35
@shakyShane shakyShane mentioned this pull request Oct 21, 2024
8 tasks
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tabbing works on Chrome and Safari. How do I get it to work on DDG though? I don’t see an option similar to the Safari one

image

@shakyShane
Copy link
Contributor Author

@mgurgel working in chromium right now is enough to move forward in windows - we can address any other platforms later :)

@shakyShane shakyShane merged commit bb9c497 into main Oct 21, 2024
11 checks passed
@shakyShane shakyShane deleted the stats_keyboard_support branch October 21, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants