Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntp: favorites drag and drop #1150

Merged
merged 2 commits into from
Nov 8, 2024
Merged

ntp: favorites drag and drop #1150

merged 2 commits into from
Nov 8, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Oct 21, 2024 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/0/0/1208684961069939/f

Description

  • Added drag+drop for favorites
  • Tested on Windows during development
  • Will be subject to security review before deployed to production

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Oct 21, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane mentioned this pull request Oct 21, 2024
Merged
10 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

[Beta] Generated file diff

Time updated: Fri, 08 Nov 2024 14:48:53 GMT

Integration 
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js
  • integration/pages/new-tab/js/mock-transport.js

File has changed

Windows 
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js
  • windows/pages/new-tab/js/mock-transport.js

File has changed

Apple 
    - dist/pages/new-tab/js/index.css
  • dist/pages/new-tab/js/index.js
  • dist/pages/new-tab/js/mock-transport.js

File has changed

@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch from 9ee0c48 to 5f0c216 Compare October 21, 2024 12:01
@shakyShane shakyShane force-pushed the stats_keyboard_support branch from 7623382 to 998dbf5 Compare October 21, 2024 12:35
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch from 5f0c216 to 35140e7 Compare October 21, 2024 12:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch from 35140e7 to d98e3de Compare October 21, 2024 15:16
@shakyShane shakyShane changed the base branch from stats_keyboard_support to 10-21-ntp_customizer_button October 21, 2024 15:16
@shakyShane shakyShane mentioned this pull request Oct 21, 2024
Merged
8 tasks
@shakyShane shakyShane force-pushed the 10-21-ntp_customizer_button branch from 5cd17c5 to b336568 Compare October 21, 2024 15:33
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch from d98e3de to e1373e3 Compare October 21, 2024 15:33
@shakyShane shakyShane marked this pull request as ready for review October 21, 2024 15:43
@shakyShane shakyShane requested review from mgurgel and a team as code owners October 21, 2024 15:43
@shakyShane shakyShane marked this pull request as draft October 21, 2024 15:44
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 1916bc0
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/672e249d4446fc00086f63d9
😎 Deploy Preview https://deploy-preview-1150--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane force-pushed the 10-21-ntp_customizer_button branch from b336568 to ea5de44 Compare October 23, 2024 07:10
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch 2 times, most recently from 91e2b7f to 0465631 Compare October 23, 2024 11:59
Base automatically changed from 10-21-ntp_customizer_button to main October 23, 2024 18:47
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch 4 times, most recently from 25a52ba to 76952de Compare October 26, 2024 16:13
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch from a1b218c to ef87a18 Compare October 31, 2024 21:14
@shakyShane shakyShane changed the base branch from main to 10-29-ntp_update_notification October 31, 2024 21:14
@shakyShane shakyShane mentioned this pull request Oct 31, 2024
Merged
10 tasks
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch from ef87a18 to cd91420 Compare October 31, 2024 21:16
Base automatically changed from 10-29-ntp_update_notification to main November 1, 2024 13:16
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch 7 times, most recently from 4f2c2ec to 2a390f5 Compare November 7, 2024 10:39
@shakyShane shakyShane changed the base branch from main to favorites_components November 7, 2024 10:39
@shakyShane shakyShane mentioned this pull request Nov 7, 2024
Merged
8 tasks
@shakyShane shakyShane force-pushed the favorites_components branch from 6aa2b84 to ea689aa Compare November 7, 2024 10:59
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch 2 times, most recently from 2b4ba7f to 6de23ca Compare November 7, 2024 16:28
@shakyShane shakyShane force-pushed the favorites_components branch from 6a062cd to 7f375e8 Compare November 7, 2024 16:30
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch from 6de23ca to 9c49cdb Compare November 7, 2024 16:30
Base automatically changed from favorites_components to main November 7, 2024 16:36
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch 2 times, most recently from d295fc1 to 182ba53 Compare November 8, 2024 10:42
@shakyShane shakyShane marked this pull request as ready for review November 8, 2024 10:48
mgurgel
mgurgel approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch from 182ba53 to 1916bc0 Compare November 8, 2024 14:47
@shakyShane
Copy link
Contributor Author

@mgurgel and I reviewed this over Zoom :)

@shakyShane shakyShane merged commit 35ecfe6 into main Nov 8, 2024
12 checks passed
@shakyShane shakyShane deleted the favorites_drag_and_drop branch November 8, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgurgel mgurgel mgurgel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shakyShane @mgurgel