Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: update notification + context menu fixes #1178

Merged
merged 11 commits into from
Nov 1, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Oct 29, 2024

Asana Task/Github Issue:

Description

  • added support for an 'updateNotification'
  • moved more docs from JS files into markdown

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Oct 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 773d537
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6724b43ee8ef010008794ba9
😎 Deploy Preview https://deploy-preview-1178--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 29, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Oct 29, 2024

[Beta] Generated file diff

Time updated: Fri, 01 Nov 2024 11:24:54 GMT

Integration
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js
  • integration/pages/new-tab/js/mock-transport.js
  • integration/pages/new-tab/locales/en/newtab.json

File has changed

Windows
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js
  • windows/pages/new-tab/js/mock-transport.js
  • windows/pages/new-tab/locales/en/newtab.json

File has changed

@shakyShane shakyShane force-pushed the 10-29-ntp_update_notification branch from 2539a9a to 2bd88b1 Compare October 31, 2024 20:19
@shakyShane shakyShane mentioned this pull request Oct 31, 2024
11 tasks
@shakyShane shakyShane marked this pull request as ready for review November 1, 2024 11:23
@shakyShane shakyShane requested review from mgurgel and a team as code owners November 1, 2024 11:23
@shakyShane shakyShane changed the title ntp: update notification ntp: update notification + context menu fixes Nov 1, 2024
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@shakyShane shakyShane merged commit 924c35b into main Nov 1, 2024
23 checks passed
@shakyShane shakyShane deleted the 10-29-ntp_update_notification branch November 1, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants