Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: favorites - add @atlaskit/pragmatic-drag-and-drop as dependency #1192

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Nov 4, 2024

Asana Task/Github Issue: https://app.asana.com/0/0/1208684961069938/f

Description

Note

Pending a new technology review approved in https://app.asana.com/0/1201141132935289/1208684961069943/f

Testing Steps

  • No changes yet, they come in the next PR

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Nov 4, 2024

Copy link

github-actions bot commented Nov 4, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Nov 4, 2024

[Beta] Generated file diff

Time updated: Tue, 05 Nov 2024 10:49:33 GMT

@shakyShane shakyShane changed the title ntp: favorites - add @atlaskit/pragmatic-drag-and-drop [Pending a new technology review] ntp: favorites - add @atlaskit/pragmatic-drag-and-drop Nov 4, 2024
@shakyShane shakyShane force-pushed the 11-04-ntp_favorites_schemas_icons branch from 9a24252 to 93f09e0 Compare November 4, 2024 10:26
@shakyShane shakyShane force-pushed the ntp_add_pragmatic-drag-and-drop branch from d0a9f9a to a44ac85 Compare November 4, 2024 10:26
@shakyShane shakyShane force-pushed the 11-04-ntp_favorites_schemas_icons branch from 93f09e0 to 0b8a0da Compare November 4, 2024 14:07
@shakyShane shakyShane force-pushed the ntp_add_pragmatic-drag-and-drop branch from a44ac85 to fcc0450 Compare November 4, 2024 14:07
@shakyShane shakyShane force-pushed the 11-04-ntp_favorites_schemas_icons branch from 0b8a0da to ceec7c6 Compare November 4, 2024 14:35
@shakyShane shakyShane force-pushed the ntp_add_pragmatic-drag-and-drop branch from fcc0450 to a5d163f Compare November 4, 2024 14:35
@shakyShane shakyShane force-pushed the 11-04-ntp_favorites_schemas_icons branch from ceec7c6 to a592452 Compare November 4, 2024 14:43
@shakyShane shakyShane force-pushed the ntp_add_pragmatic-drag-and-drop branch 2 times, most recently from 59d1ced to 303d7ad Compare November 4, 2024 14:50
Base automatically changed from 11-04-ntp_favorites_schemas_icons to main November 4, 2024 15:06
@shakyShane shakyShane force-pushed the ntp_add_pragmatic-drag-and-drop branch from 303d7ad to 41f7d0a Compare November 4, 2024 16:55
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 41f7d0a
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6728fc7bd9ab9300087d64e7
😎 Deploy Preview https://deploy-preview-1192--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane changed the title [Pending a new technology review] ntp: favorites - add @atlaskit/pragmatic-drag-and-drop ntp: favorites - add @atlaskit/pragmatic-drag-and-drop as dependency Nov 5, 2024
@shakyShane shakyShane marked this pull request as ready for review November 5, 2024 10:48
@shakyShane shakyShane requested review from mgurgel and a team as code owners November 5, 2024 10:48
@shakyShane shakyShane assigned shakyShane and mgurgel and unassigned shakyShane Nov 5, 2024
@shakyShane
Copy link
Contributor Author

@mgurgel just a separate PR to keep the package-lock changes from bloating other PRs

@shakyShane shakyShane merged commit 3790936 into main Nov 5, 2024
21 checks passed
@shakyShane shakyShane deleted the ntp_add_pragmatic-drag-and-drop branch November 5, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants