Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using ts direct from privacy config #1211

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

jonathanKingston
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/0/481882893211075/1208516641945153/f

Description

Switches us over to using the TS from the privacy-configuration repo.

Needs: https://github.com/duckduckgo/privacy-configuration/pull/2444/files and duckduckgo/privacy-configuration#2439

Draft as the config changes still need review, this was to ensure there's no issues on our side.
/cc @sammacbeth and @shakyShane

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 2444204
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6731dec1bef51f0008377e65
😎 Deploy Preview https://deploy-preview-1211--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 8, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Nov 8, 2024

[Beta] Generated file diff

Time updated: Mon, 11 Nov 2024 10:43:35 GMT

Android
    - android/contentScope.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScopeIsolated.js

File has changed

@jonathanKingston jonathanKingston marked this pull request as ready for review November 11, 2024 10:42
@jonathanKingston jonathanKingston requested a review from a team as a code owner November 11, 2024 10:42
@jonathanKingston jonathanKingston merged commit 92f6b94 into main Nov 11, 2024
19 checks passed
@jonathanKingston jonathanKingston deleted the jkt/switch-types branch November 11, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants