-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Typescript for config schemas #2439
Conversation
Generated file outputs:Time updated: Fri, 08 Nov 2024 16:55:38 GMT legacytrackers-unprotected-temporary.txt (14 more)
latestv4/android-config.json (13 more)
|
Before we merge this I want to make sure C-S-S doesn't explode. We had some auto routing of the types so the No real issues otherwise from a quick glance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I played around with it a bit and also linked it into C-S-S fairly easily (no other consumers exist to these types that I'm aware of).
There's a bunch of fast follows like:
- Typing out some of the C-S-S stuff to be shared a bit better to help feature authors with the domain patching stuff but that's certainly not a blocker as we didn't have anything here.
- I think we can remove both duckplayer and webcompat test now this change links the testing in automatically for those settings. (Happy to remove these as a follow up if that's the case).
On risk to merge:
- It looks like you've copied over what typing we already had (and added more).
Given that until recently we weren't even blocking merges on tests passing; we can take the risk on some edge cases of these being a little looser than they might have been (I couldn't spot any other than the feature name that you fixed :) ). - Additionally if the typing is slightly too restrictive, I think it's not a huge concern either.
Feel free to merge when ready 👍🏻
Asana Task/Github Issue: https://app.asana.com/0/481882893211075/1208516641945153/f
Description
Reference