Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phishing error page #972

Closed
wants to merge 24 commits into from
Closed

Phishing error page #972

wants to merge 24 commits into from

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Jun 4, 2024

Reviewer: @shakyShane
Asana: https://app.asana.com/0/1206594217596623/1207161330052430/f

Implements Special Error Page for displaying SSL and Phishing warnings

Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! just a couple of small comments :)

packages/special-pages/tests/page-objects/specialerror.js Outdated Show resolved Hide resolved
packages/special-pages/tests/page-objects/specialerror.js Outdated Show resolved Hide resolved
packages/special-pages/tests/specialerror.spec.js Outdated Show resolved Hide resolved
@mgurgel mgurgel requested a review from shakyShane June 5, 2024 09:12
shakyShane
shakyShane previously approved these changes Jun 5, 2024
@shakyShane
Copy link
Contributor

@mgurgel if you rebase this against main, you'll get the automated release branch for @not-a-rootkit to use.

@duckduckgo duckduckgo deleted a comment from github-actions bot Jul 25, 2024
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@duckduckgo duckduckgo deleted a comment from github-actions bot Jul 25, 2024
@shakyShane
Copy link
Contributor

@mgurgel I think this is no-longer needed?

@mgurgel
Copy link
Contributor Author

mgurgel commented Sep 19, 2024

Closed in favor of #1009

@mgurgel mgurgel closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants