use message to open duckplayer from overlay #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shakyShane and the rest of your teammates on |
This was referenced Jul 8, 2024
shakyShane
force-pushed
the
shane/duckplayer-open
branch
from
2a4fd4e to
040aec4
Compare
Bunn
previously approved these changes
Jul 8, 2024
shakyShane
force-pushed
the
shane/duckplayer-open
branch
from
040aec4 to
e724efc
Compare
shakyShane
force-pushed
the
shane/duckplayer-open
branch
from
56832ff to
886ef91
Compare
shakyShane
force-pushed
the
shane/duckplayer-open
branch
from
bdf08a2 to
ac6f6c8
Compare
shakyShane
changed the base branch from
main
to
07-11-simpler_playwright_test_definitions_for_special_pages
shakyShane
force-pushed
the
shane/duckplayer-open
branch
2 times, most recently
from
74238ee to
8eef7fb
Compare
Base automatically changed from
07-11-simpler_playwright_test_definitions_for_special_pages
to
main
July 11, 2024 11:22
shakyShane
force-pushed
the
shane/duckplayer-open
branch
from
8eef7fb to
d188692
Compare
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
shakyShane
commented
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1201141132935289/1207702853516473/f
This just removes a single instance where the page location was updated by the JS.
Note This needs testing on macOS + Windows