Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simpler playwright test definitions for special pages #996

Merged

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Jul 11, 2024

TL;DR

Consolidated Playwright configurations for Windows and MacOS in special-pages/playwright.config.js by merging respective Apple and Windows configurations and reducing redundancy.

What changed?

  • Merged several Apple and Windows specific configurations into singular platform-based configurations.
  • Updated testMatch arrays to include multiple spec files for each platform.

How to test?

  1. If the tests all pass, we're all good

Why make this change?

When adding more platforms and more projects, I realised this way would be easier to manage


@shakyShane
Copy link
Contributor Author

shakyShane commented Jul 11, 2024

@shakyShane shakyShane marked this pull request as ready for review July 11, 2024 10:40
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@duckduckgo duckduckgo deleted a comment from github-actions bot Jul 11, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Jul 11, 2024
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests are passing. Nice 👍

@shakyShane shakyShane merged commit 41874eb into main Jul 11, 2024
6 checks passed
@shakyShane shakyShane deleted the 07-11-simpler_playwright_test_definitions_for_special_pages branch July 11, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants