Prevent in-context signup showing on local or invalid domain pages #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistairjcbrown
commented
Feb 24, 2023
alistairjcbrown
force-pushed
the
abrown/prevent-incontext-signup-on-local-pages
branch
from
375e5a6
to
a5b808e
Compare
GioSensation
requested changes
Feb 27, 2023
alistairjcbrown
force-pushed
the
abrown/prevent-incontext-signup-on-local-pages
branch
2 times, most recently
from
d6618af
to
361d923
Compare
alistairjcbrown
force-pushed
the
abrown/prevent-incontext-signup-on-local-pages
branch
from
361d923
to
813653f
Compare
|
@GioSensation @shakyShane Integration test setup updated. Any other comments? |
shakyShane
requested changes
Feb 28, 2023
shakyShane
approved these changes
Feb 28, 2023
GioSensation
approved these changes
Feb 28, 2023
alistairjcbrown
changed the base branch from
main
to
abrown/changes-to-in-context-signup-treatment
alistairjcbrown
merged commit 741ed92
into
abrown/changes-to-in-context-signup-treatment
alistairjcbrown
deleted the
abrown/prevent-incontext-signup-on-local-pages
branch
alistairjcbrown
added a commit
that referenced
this pull request
Mar 23, 2023
* Prevent in-context signup showing on local or invalid domain pages (#263) * Don't open in-context signup on input click (#264) * Show grayscale Dax icon for in-context signup (#265) * Remove initial dismissal in favor of single permanent dismissal (#266) * Only show in-context signup if recently installed (#267) * Adds a close X button to the top right of the tooltip (#268) * Fix grayscale dax logo (#271) * Ema/prevent focus extensions (#270) * Update icon asset to fix grayscale version (#276) * Improve narrow width iframes (#273) * Add Email Protection tooltip pixel (#277) * Fade Dax icon in on hover for in-context signup (#278) * Fade Dax icon in on hover for in-context signup * Keep Dax icon with active styles when tooltip open * Prevent icon flicker when clicking Dax icon for open tooltip * Move style management into form * Position tooltip above input when no space below (#282) * Position tooltip above input when no space below * Preload webfonts before showing tooltip This prevents the fonts loading in once the tooltip is shown and causing a layout shift. This is more important when the tooltip is showing above the input, as it can cause the tooltip to jump up. * Check tooltip position after revealed and bail if called before When running on slower devices, the tooltip position may be checked before the tooltip is revealed. When this happens, we now bail early without updating the position. Check position is now called after styles have loaded, when we know the tooltip is visible. * Hide caret initially and reduce position calculation calls * Read hidden attribute from DOM Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com> * Fix linting issue with playwright report Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com> * Rename typoed file Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com> --------- Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com> Co-authored-by: Emanuele Feliziani <feliziani.emanuele@gmail.com> --------- Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com> Co-authored-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane @GioSensation
Asana: https://app.asana.com/0/0/1204038361216231/f
Description
Restrict in-context signup from running on local pages with valid TLD. This branch also updates the in-context signup tests to run on a real domain, mocked in puppeteer.
Steps to test
email-autofill.htmlintegration test file