Abrown/changes to in context signup treatment #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… abrown/changes-to-in-context-signup-treatment
* Fade Dax icon in on hover for in-context signup * Keep Dax icon with active styles when tooltip open * Prevent icon flicker when clicking Dax icon for open tooltip * Move style management into form
* Position tooltip above input when no space below * Preload webfonts before showing tooltip This prevents the fonts loading in once the tooltip is shown and causing a layout shift. This is more important when the tooltip is showing above the input, as it can cause the tooltip to jump up. * Check tooltip position after revealed and bail if called before When running on slower devices, the tooltip position may be checked before the tooltip is revealed. When this happens, we now bail early without updating the position. Check position is now called after styles have loaded, when we know the tooltip is visible. * Hide caret initially and reduce position calculation calls * Read hidden attribute from DOM Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com> * Fix linting issue with playwright report Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com> * Rename typoed file Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com> --------- Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com> Co-authored-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
GioSensation
approved these changes
Mar 23, 2023
.
alistairjcbrown
deleted the
abrown/changes-to-in-context-signup-treatment
branch
This was referenced Mar 23, 2023
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Mar 23, 2023
Task/Issue URL: https://app.asana.com/0/1204250253793536/1204250253793536 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/6.4.1 ## Description Updates Autofill to version [6.4.1](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/6.4.1). ### Autofill 6.4.0 and 6.4.1 release notes ## What's Changed ### Tooling and Tests * Update integration tests for in-context signup by @alistairjcbrown in duckduckgo/duckduckgo-autofill#254 and duckduckgo/duckduckgo-autofill#255 * Update macOS browser repository ID in `asana-release.yml` by @ayoy in duckduckgo/duckduckgo-autofill#259 * Use node v18 and update actions to read `.nvmrc` file by @alistairjcbrown in duckduckgo/duckduckgo-autofill#269 * Bugfix: Update release script to add checkout path to node version file path by @alistairjcbrown in duckduckgo/duckduckgo-autofill#286 ### Source Code Updates * Refactor in-context state to feature file by @shakyShane in duckduckgo/duckduckgo-autofill#251 * Prevent duplicated schema types by using JSON schema throughout by @shakyShane in duckduckgo/duckduckgo-autofill#253 * Stop scanning pages with a large number of inputs by @alistairjcbrown in duckduckgo/duckduckgo-autofill#257 and duckduckgo/duckduckgo-autofill#262 * Ignore small email inputs by @alistairjcbrown in duckduckgo/duckduckgo-autofill#261 * Fix username not saved by @GioSensation in duckduckgo/duckduckgo-autofill#275 * Updates to in-context signup treatment by @alistairjcbrown and @GioSensation in duckduckgo/duckduckgo-autofill#284 **Full Changelog**: duckduckgo/duckduckgo-autofill@6.3.0...6.4.1 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: alistairjcbrown <alistairjcbrown@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Asana: https://app.asana.com/0/0/1204084632769511/f
Description
Release branch for in-context signup updates
Steps to test
Each commit has been tested as built. See each commit for details.