Stop scanning pages with a large number of inputs #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakyShane
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
@alistairjcbrown thanks!
I've approved the code-changes, but I have to caveat the approval by saying I've not actually tested this in any of our browsers etc :)
alistairjcbrown
deleted the
abrown/stop-scanner-for-pages-with-lots-of-inputs
branch
This was referenced Mar 23, 2023
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Mar 23, 2023
Task/Issue URL: https://app.asana.com/0/1204250253793536/1204250253793536 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/6.4.1 ## Description Updates Autofill to version [6.4.1](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/6.4.1). ### Autofill 6.4.0 and 6.4.1 release notes ## What's Changed ### Tooling and Tests * Update integration tests for in-context signup by @alistairjcbrown in duckduckgo/duckduckgo-autofill#254 and duckduckgo/duckduckgo-autofill#255 * Update macOS browser repository ID in `asana-release.yml` by @ayoy in duckduckgo/duckduckgo-autofill#259 * Use node v18 and update actions to read `.nvmrc` file by @alistairjcbrown in duckduckgo/duckduckgo-autofill#269 * Bugfix: Update release script to add checkout path to node version file path by @alistairjcbrown in duckduckgo/duckduckgo-autofill#286 ### Source Code Updates * Refactor in-context state to feature file by @shakyShane in duckduckgo/duckduckgo-autofill#251 * Prevent duplicated schema types by using JSON schema throughout by @shakyShane in duckduckgo/duckduckgo-autofill#253 * Stop scanning pages with a large number of inputs by @alistairjcbrown in duckduckgo/duckduckgo-autofill#257 and duckduckgo/duckduckgo-autofill#262 * Ignore small email inputs by @alistairjcbrown in duckduckgo/duckduckgo-autofill#261 * Fix username not saved by @GioSensation in duckduckgo/duckduckgo-autofill#275 * Updates to in-context signup treatment by @alistairjcbrown and @GioSensation in duckduckgo/duckduckgo-autofill#284 **Full Changelog**: duckduckgo/duckduckgo-autofill@6.3.0...6.4.1 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: alistairjcbrown <alistairjcbrown@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation @shakyShane
Asana: https://app.asana.com/0/1198964220583541/1203995347288602/f
Description
Stop scanning pages with a large number of inputs
Steps to test