fix: prevent duplicated schema types by using JSON schema throughout #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Password rules outdatedYou can update the rules with the following command cd packages/password && npm run rules:updateOnce you've updated the rules, re-run the build from the root with |
GioSensation
approved these changes
Feb 15, 2023
This was referenced Mar 23, 2023
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Mar 23, 2023
Task/Issue URL: https://app.asana.com/0/1204250253793536/1204250253793536 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/6.4.1 ## Description Updates Autofill to version [6.4.1](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/6.4.1). ### Autofill 6.4.0 and 6.4.1 release notes ## What's Changed ### Tooling and Tests * Update integration tests for in-context signup by @alistairjcbrown in duckduckgo/duckduckgo-autofill#254 and duckduckgo/duckduckgo-autofill#255 * Update macOS browser repository ID in `asana-release.yml` by @ayoy in duckduckgo/duckduckgo-autofill#259 * Use node v18 and update actions to read `.nvmrc` file by @alistairjcbrown in duckduckgo/duckduckgo-autofill#269 * Bugfix: Update release script to add checkout path to node version file path by @alistairjcbrown in duckduckgo/duckduckgo-autofill#286 ### Source Code Updates * Refactor in-context state to feature file by @shakyShane in duckduckgo/duckduckgo-autofill#251 * Prevent duplicated schema types by using JSON schema throughout by @shakyShane in duckduckgo/duckduckgo-autofill#253 * Stop scanning pages with a large number of inputs by @alistairjcbrown in duckduckgo/duckduckgo-autofill#257 and duckduckgo/duckduckgo-autofill#262 * Ignore small email inputs by @alistairjcbrown in duckduckgo/duckduckgo-autofill#261 * Fix username not saved by @GioSensation in duckduckgo/duckduckgo-autofill#275 * Updates to in-context signup treatment by @alistairjcbrown and @GioSensation in duckduckgo/duckduckgo-autofill#284 **Full Changelog**: duckduckgo/duckduckgo-autofill@6.3.0...6.4.1 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: alistairjcbrown <alistairjcbrown@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana:
Description
The main entry point for defining API calls is now expressed in JSON schema for consistency. This has the nice side-effect of solving the 'duplicated types' problem described in the tasks above because we are no longer building the schema up ourselves in the JS.
Steps to test
If TS + integration tests pass, then we're all good here :)