Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Configuration Management #1512

Merged
merged 18 commits into from
Mar 8, 2023
Merged

Unify Configuration Management #1512

merged 18 commits into from
Mar 8, 2023

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Feb 22, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1203797041821336/f
Tech Design URL:
CC: @bwaresiak

Description:
Use common API and Configuration modules located in BSK for fetching privacy related assets.
Add payload validation.

Steps to test this PR:

  1. Run tests
  2. Check if app downloads assets.
  3. Check if app sends etag in requests.
  4. Check if app handles 304s.
  5. Check if app stores the resources.
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@jaceklyp jaceklyp mentioned this pull request Feb 22, 2023
Merged
@github-actions
Copy link

github-actions bot commented Mar 7, 2023 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 67d7958

ayoy
ayoy approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I’ve tested configuration fetching, autocomplete suggestions and waitlist requests, including from a background task. All works flawlessly 💪

@ayoy ayoy assigned jaceklyp and unassigned ayoy Mar 8, 2023
jaceklyp added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Mar 8, 2023
@jaceklyp
Unify Configuration Management (#241)
c10bf52 
Task/Issue URL: https://app.asana.com/0/72649045549333/1203797041821336/f
iOS PR: duckduckgo/iOS#1512
macOS PR: duckduckgo/macos-browser#990

Description:
Use common API and Configuration modules located in BSK for fetching privacy related assets.
Add payload validation.
@jaceklyp jaceklyp merged commit 6a0b7d5 into develop Mar 8, 2023
@jaceklyp jaceklyp deleted the jacek/unify-configuration branch March 8, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayoy ayoy ayoy approved these changes

Assignees

@jaceklyp jaceklyp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaceklyp @ayoy