Unify Configuration Management #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
reviewed
Feb 24, 2023
| case .privacyConfiguration: return URL(string: "https://staticcdn.duckduckgo.com/trackerblocking/config/v2/macos-config.json")! | ||
| case .surrogates: return URL(string: "https://duckduckgo.com/contentblocking.js?l=surrogates")! | ||
| case .trackerDataSet: return URL(string: "https://staticcdn.duckduckgo.com/trackerblocking/v3/apple-tds.json")! | ||
| // In archived repo, to be refactored shortly (https://staticcdn.duckduckgo.com/useragents/social_ctp_configuration.json) |
There was a problem hiding this comment.
Is this comment still relevant? If so, can you make it more clear? (I have no idea what is it about)
| @@ -24,7 +24,7 @@ public struct UserDefaultsWrapper<T> { | |||
| public enum Key: String, CaseIterable { | |||
|
|
|||
| case configLastUpdated = "config.last.updated" | |||
| case configStorageTrackerRadarEtag = "config.storage.trackerradar.etag" | |||
| case configStorageTrackerRadarEtag = "config.storage.trackerDataSet.etag" | |||
There was a problem hiding this comment.
Won't we need some migration code to recognize an etag stored under the old name?
bwaresiak
reviewed
Feb 24, 2023
| #endif | ||
|
|
||
| Pixel.fire(.debug(event: .trackerDataCouldNotBeLoaded, error: error)) |
There was a problem hiding this comment.
That is getting fired on a fresh installation, I don't think it's intended.
jaceklyp
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Mar 8, 2023
Task/Issue URL: https://app.asana.com/0/72649045549333/1203797041821336/f iOS PR: duckduckgo/iOS#1512 macOS PR: duckduckgo/macos-browser#990 Description: Use common API and Configuration modules located in BSK for fetching privacy related assets. Add payload validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1203797041821336/f
Tech Design URL:
CC: @bwaresiak
Description:
Use common API and Configuration modules located in BSK for fetching privacy related assets.
Add payload validation.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM