bump BSK #1737
Merged
bump BSK #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
ayoy
approved these changes
May 25, 2023
There was a problem hiding this comment.
LGTM! @shakyShane in case you’re not familiar with BSK release process, please remember to first merge BSK PR, tag it and make a release in GitHub, and then update platform PRs to point to a version. Thanks!
shakyShane
force-pushed
the
shane/bump-bsk-messaging
branch
from
d0f7ed9
to
26e1319
Compare
shakyShane
force-pushed
the
shane/bump-bsk-messaging
branch
from
26e1319
to
253acdc
Compare
samsymons
added a commit
that referenced
this pull request
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1204657512710034/f
Tech Design URL:
CC:
Description:
Update macOS to use latest BSK https://app.asana.com/0/0/1204544767438474/f
Those changes to BSK are all additions - there are no functional changes to macOS in this PR, it's just keeping it up to date to allow ClickToLoad, DataBrokerProtection and DuckPlayer to use them.
BSK PR: duckduckgo/BrowserServicesKit#299
Steps to test this PR:
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template