Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Engine with support for syncing bookmarks #1724

Merged
merged 62 commits into from
May 26, 2023
Merged

Sync Engine with support for syncing bookmarks #1724

merged 62 commits into from
May 26, 2023

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented May 16, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1204606874917765/f

Description:
Add support for syncing bookmarks. See BSK PR for more info and testing steps.

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

ayoy added 25 commits April 13, 2023 11:34
@ayoy
Update Bookmarks/Favorites code to support v3 model (isPendingDeletion)
2bd46f7
@ayoy
Clean up deleted bookmarks on app startup, data cleanup and on schedu…
2fc896c 
…le (every 24h)
@ayoy
Fix MockDependencyProvider compilation
955b776
@ayoy
Add Bookmarks indexes tests
542658e
@ayoy
Fix Swiftlint violation
c774b79
@ayoy
Move Sync Service back to AppDelegate and inject it to MainViewContro…
73948e2 
…ller via initializer
@ayoy
Merge branch 'develop' into dominik/bookmarks-v3
f7c8d91
@ayoy
Merge branch 'develop' into dominik/bookmarks-v3
bc2f87f
@ayoy
Add initial support for syncing bookmarks
e371449
@ayoy
Trigger sync on bookmark edit's save
cdcc373
@ayoy
Request sync immediately on app lifecycle event (temporarily)
ff89830
@ayoy
Merge branch 'develop' into dominik/bookmarks-v3
6475b8f
@ayoy
Merge branch 'dominik/bookmarks-v3' into dominik/sync-engine
f5a2152
@ayoy
Update BSK ref
7486196
@ayoy
Rename SyncBookmarksProvider as BookmarksProvider
58f1e0a
@ayoy
Merge branch 'develop' into dominik/bookmarks-v3
954170c
@ayoy
Merge branch 'dominik/bookmarks-v3' into dominik/sync-engine
5525cd4
@ayoy
Update BSK ref
48b9330
@ayoy
Update BSK ref
a2b4e61
@ayoy
Add syncMetadataCouldNotLoadDatabase debug Pixel
4a402eb
@ayoy
Add Sync Log
092b813
@ayoy
Add background scheduled task for sync
935e48d
@ayoy
Use syncService.isInProgressPublisher in background task handler
55da015
@ayoy
Update BSK ref
e68590a
@ayoy
Log bookmarks sync errors to Sync logger
4cc4c3b
@ayoy ayoy self-assigned this May 16, 2023
@ayoy ayoy mentioned this pull request May 16, 2023
Merged
6 tasks
ayoy added 17 commits May 18, 2023 13:23
@ayoy
Update BSK ref (fix fetching orphaned bookmarks after move/delete)
a034958
@ayoy
Request sync on 'Add Bookmark' context menu action
bc707da
@ayoy
Update WIP message in Sync Settings
46b1b1b
@ayoy
Update BSK ref
988b442
@ayoy
Add syncBookmarksFailed Pixel debug event and fire it from Bookmarks …
f12a60b 
…Adapter error handler
@ayoy
Update BSK ref
d323c50
@ayoy
Ignore DerivedData directory from linting
f79ee82
@ayoy
Merge branch 'develop' into dominik/sync-engine
5c8dfa1
@ayoy
Include orphaned entities in Bookmarks export
2c29ab8
@ayoy
Update BSK ref
04b0c32
@ayoy
Update BSK for removed BookmarkEntity.isFavorite field
7b8ffcf
@ayoy
Update BSK ref to fix deduplicating root folder
9468806
@ayoy
Request sync after editing and deleting favorites in favorites view
c3a1111
@ayoy
Request sync after adding bookmark/favorite from share menu
526bd6f
@ayoy
Ignore URL sync errors
a954c74
@ayoy
Fire a Pixel when BookmarksProvider initialization fails
0be8f66
@ayoy
Update BSK ref to include prepareForFirstSync errors in providers' er…
bf45c7b 
…ror handler
bwaresiak
bwaresiak reviewed May 26, 2023
View reviewed changes
DuckDuckGo/AddOrEditBookmarkViewController.swift
@@ -121,6 +121,7 @@ class AddOrEditBookmarkViewController: UIViewController {
WidgetCenter.shared.reloadAllTimelines()
self.delegate?.finishedEditing(self, entityID: viewModel.bookmark.objectID)
dismiss(animated: true, completion: nil)
(UIApplication.shared.delegate as? AppDelegate)?.requestSyncIfEnabled()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I'd like this to be passed down as dependency here and in other places, but it's not important for this PR - let's tweak it when preparing further tweaks. :)

bwaresiak
bwaresiak approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@ayoy ayoy assigned ayoy and unassigned bwaresiak May 26, 2023
@ayoy ayoy merged commit 286fd55 into develop May 26, 2023
@ayoy ayoy deleted the dominik/sync-engine branch May 26, 2023 10:12
samsymons added a commit that referenced this pull request May 29, 2023
@samsymons
Merge branch 'develop' into brad/apptp-design-review
f5c83cc 
* develop:
  Release 7.75.0 (#1750)
  Update BSK with autofill 7.1.0 (#1749)
  Autofill password generation support for iOS (#1736)
  Sync Engine with support for syncing bookmarks (#1724)
  bump BSK (#1737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaresiak bwaresiak bwaresiak approved these changes

Assignees

@ayoy ayoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayoy @bwaresiak