Sync Engine with support for syncing bookmarks #355
Merged
+5,293
−608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so received from server
…d make SyncFeature a struct
…dels it needs to decode
…tion function that handles children
…vorites are present
…g for favoriteFolder)
… to create PATCH request body
bwaresiak
reviewed
May 25, 2023
… error handler before rethrowing
bwaresiak
reviewed
May 26, 2023
| while true { | ||
| let bookmarksPendingDeletion = fetchBookmarksPendingDeletion(context) | ||
| if bookmarksPendingDeletion.isEmpty { | ||
| print("No bookmarks pending deletion") |
There was a problem hiding this comment.
Shouldn't these be os logs? :)
There was a problem hiding this comment.
Sure, I forgot to update them, let me handle this now :)
samsymons
added a commit
that referenced
this pull request
Jun 19, 2023
* main: (45 commits) SecureVault Keychain updates (#382) Reattach orphaned bookmarks to root folder when reordering (#383) Allow for asynchronous sync initialization (#381) Drop regex support in param stripping (#367) mac promo exp2 - add support for share link message (#375) Revert accidentally pushed change Remove test that was dependant on the keychain Add item to keychain in the background (#380) macOS in-context signup updates (#359) Fixes the format in a log call (#379) Add EventMapping to DDGSync dependencies and call it from handleUnauthenticated (#376) Autofill hash migration updates + Bitwarden hotfix (#372) Autofill password generation support for iOS (#361) Update autofill to 7.1.0 (#370) Sync Engine with support for syncing bookmarks (#355) Centralised Messaging for User Scripts (#299) Update TLD accounts query to be more specific (#368) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#366) Adds a different hash Account per each macOS build kind (#363) adjust os_log parameter name using disfavoredOverload (#349) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1204606874917765/f
iOS PR: duckduckgo/iOS#1724
macOS PR: duckduckgo/macos-browser#1203
What kind of version bump will this require?: Major
Optional:
Tech Design URL:
Description:
Changes to bookmarks:
isPendingDeletionandmodifiedAtand removes soft-deleted bookmarks.
Changes to Sync:
isAuthenticatedwithSyncAuthStateenum (inactive, setupNewAccount, addNewDevice, active)SyncSchedulingandDataProvidingpublic protocols. MadeCryptingpublic too.SyncMetadataCore Data model,SyncMetadataStoreclass andSyncFeatureEntityclass representing a syncable model.New module – SyncDataProviders:
BookmarkProvider, it’s an implementation ofDataProvidingfor handling bookmarks.The logic is fully reused in iOS and macOS apps.
Recommended reading order:
(other changes under Bookmarks models are related to iOS app UI)
Steps to test this PR:
To speed up testing sync you may want to set
SyncScheduler.appLifecycleEventsDebounceIntervalto 1.dominik/sync-enginebranches on both clients and run the app again. Make sure that the app didn’t crash at startup due to failed migration.OS Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template