macOS in-context signup updates #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistairjcbrown
commented
May 19, 2023
Package.swift
Outdated
| @@ -26,7 +26,7 @@ let package = Package( | |||
| .library(name: "Navigation", targets: ["Navigation"]), | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/duckduckgo/duckduckgo-autofill.git", exact: "7.0.1"), | |||
| .package(url: "https://github.com/duckduckgo/duckduckgo-autofill.git", revision: "2fa8222"), | |||
There was a problem hiding this comment.
Pointing to in-review branch -- duckduckgo/duckduckgo-autofill#317
This will be updated before merging to an autofill release
alistairjcbrown
force-pushed
the
daniel/macos-incontext-signup-updates
branch
2 times, most recently
from
d80b4c0
to
61fc43b
Compare
alistairjcbrown
force-pushed
the
daniel/macos-incontext-signup-updates
branch
4 times, most recently
from
850fa8e
to
74728c8
Compare
alistairjcbrown
requested review from
a team,
jaceklyp and
jotaemepereira
and removed request for
a team and
jaceklyp
|
@afterxleep Ooops, looks like this branch got deleted. Want me to rename it under |
alistairjcbrown
force-pushed
the
daniel/macos-incontext-signup-updates
branch
from
74728c8
to
0afd1c3
Compare
…tofillUserScript+Email.swift and added delegate functions to get / set dismissed status from EmailManager
alistairjcbrown
force-pushed
the
daniel/macos-incontext-signup-updates
branch
from
0afd1c3
to
0c818a7
Compare
alistairjcbrown
force-pushed
the
daniel/macos-incontext-signup-updates
branch
2 times, most recently
from
33e0123
to
6250bda
Compare
alistairjcbrown
force-pushed
the
daniel/macos-incontext-signup-updates
branch
from
6250bda
to
9475ad4
Compare
|
Autofill update commit cherry-picked from #377 |
samsymons
added a commit
that referenced
this pull request
Jun 19, 2023
* main: (45 commits) SecureVault Keychain updates (#382) Reattach orphaned bookmarks to root folder when reordering (#383) Allow for asynchronous sync initialization (#381) Drop regex support in param stripping (#367) mac promo exp2 - add support for share link message (#375) Revert accidentally pushed change Remove test that was dependant on the keychain Add item to keychain in the background (#380) macOS in-context signup updates (#359) Fixes the format in a log call (#379) Add EventMapping to DDGSync dependencies and call it from handleUnauthenticated (#376) Autofill hash migration updates + Bitwarden hotfix (#372) Autofill password generation support for iOS (#361) Update autofill to 7.1.0 (#370) Sync Engine with support for syncing bookmarks (#355) Centralised Messaging for User Scripts (#299) Update TLD accounts query to be more specific (#368) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#366) Adds a different hash Account per each macOS build kind (#363) adjust os_log parameter name using disfavoredOverload (#349) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1204636039042602/f
iOS PR: duckduckgo/iOS#1756
macOS PR: duckduckgo/macos-browser#1209
What kind of version bump will this require?: Major -- a new parameter is added to
ContentScopeFeatureTogglesOptional:
Tech Design URL:
CC: @amddg44 @afterxleep
Description:
Adds support for getting and setting in-context signup dismissal, as well as opening and closing the Email Protection web app tab for users signing-in/signiing-up
Steps to test this PR:
1.
1.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template