Fixes the format in a log call #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2023
afterxleep
approved these changes
Jun 8, 2023
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jun 9, 2023
Task/Issue URL: https://app.asana.com/0/0/1204785816528431/f BSK: duckduckgo/BrowserServicesKit#379 macOS: duckduckgo/macos-browser#1249 Description Fixes a string formatting issue that crashes the app in debug builds, when Bookmarks logging is ON.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jun 9, 2023
Task/Issue URL: https://app.asana.com/0/1203108348835387/1204785816528431/f BSK: duckduckgo/BrowserServicesKit#379 iOS: duckduckgo/iOS#1760 ## Description: Fixes a string formatting issue that crashes the app in debug builds, when Bookmarks logging is ON.
samsymons
added a commit
that referenced
this pull request
Jun 19, 2023
* main: (45 commits) SecureVault Keychain updates (#382) Reattach orphaned bookmarks to root folder when reordering (#383) Allow for asynchronous sync initialization (#381) Drop regex support in param stripping (#367) mac promo exp2 - add support for share link message (#375) Revert accidentally pushed change Remove test that was dependant on the keychain Add item to keychain in the background (#380) macOS in-context signup updates (#359) Fixes the format in a log call (#379) Add EventMapping to DDGSync dependencies and call it from handleUnauthenticated (#376) Autofill hash migration updates + Bitwarden hotfix (#372) Autofill password generation support for iOS (#361) Update autofill to 7.1.0 (#370) Sync Engine with support for syncing bookmarks (#355) Centralised Messaging for User Scripts (#299) Update TLD accounts query to be more specific (#368) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#366) Adds a different hash Account per each macOS build kind (#363) adjust os_log parameter name using disfavoredOverload (#349) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1204785816528431/f
iOS PR: duckduckgo/iOS#1760
macOS PR: duckduckgo/macos-browser#1249
What kind of version bump will this require?: Patch
CC: @ayoy
Description
Fixes a string formatting issue that crashes the app in debug builds, when Bookmarks logging is ON.
Testing
Please refer to the iOS and macOS PRs for testing steps.
OS Testing
Internal references:
Software Engineering Expectations
Technical Design Template