Add Pixel for sync unauthenticated response #376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1204729420609454/f
iOS PR: duckduckgo/iOS#1757
macOS PR: duckduckgo/macos-browser#1246
What kind of version bump will this require?: Major
Description:
Add support for reporting errors from DDGSync class via EventMapping. Report unauthenticated error.
Steps to test this PR:
On the client:
sync_sent_unauthenticated_request
debug pixel is fired (with["d": "DDGSync.SyncError", "e": "1"]
parameters).OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template