Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pixel for sync unauthenticated response #1757

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Jun 2, 2023

Task/Issue URL: https://app.asana.com/0/0/1204729420609454/f

Description:
Report sync HTTP 401 responses as pixels.

Steps to test this PR:
See duckduckgo/BrowserServicesKit#376 for steps to test.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Jun 2, 2023
@ayoy ayoy assigned brindy and unassigned ayoy Jun 2, 2023
@ayoy ayoy marked this pull request as ready for review June 2, 2023 10:08
@brindy brindy self-requested a review June 2, 2023 10:46
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy assigned ayoy and unassigned brindy Jun 2, 2023
@ayoy ayoy merged commit f331107 into develop Jun 2, 2023
@ayoy ayoy deleted the dominik/sync-error-reporting branch June 2, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants