Manage Duck Addresses #1828
Merged
Manage Duck Addresses #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afterxleep
force-pushed
the
daniel/private-emails
branch
from
ec98e38
to
6d39e3f
Compare
afterxleep
force-pushed
the
daniel/private-emails
branch
from
09b84aa
to
391d248
Compare
This was referenced Jul 19, 2023
amddg44
requested changes
Jul 26, 2023
There was a problem hiding this comment.
@afterxleep it looks like there is still an issue with state not being properly reset. I was running through your test steps and found (and can reproduce consistently):
- If I test 3b from a fresh app launch, everything is good
- If I test 3a, and then 3b in the same session my personal duck address saves automatically
I spent some time digging into this and it looks to me that autogeneratedCredentials in SecureVaultManager is not being reset correctly to false after 3a
My exact test steps were:
- On
fill.devI generated a private address and entered a manual password - Credentials were saved automatically ✅
- I deleted this login and went back and chose my personal duck address
- Before entering a password or tapping submit, I checked Logins and found a partial login saved with my personal duck address
|
@amddg44 Looking into this |
@amddg44 I've made a couple minor updates to split the logic between autogenerated usernames and passwords, updated a test and added a new one to cover for this particular scenario:
|
amddg44
requested changes
Aug 2, 2023
There was a problem hiding this comment.
@afterxleep nice work! just a couple of nits (mostly removing some dead code) 🙂
amddg44
approved these changes
Aug 3, 2023
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/AutofillLoginDetailsViewModel.swift # DuckDuckGo/TabViewController.swift
afterxleep
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 3, 2023
Task/Issue URL: https://app.asana.com/0/72649045549333/1204615490114675/f iOS PR: duckduckgo/iOS#1828 macOS PR: duckduckgo/macos-browser#1319 What kind of version bump will this require?: Minor Description: Allows users to manage their Private Email addresses from the browser.
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/UserText.swift # DuckDuckGo/en.lproj/Localizable.strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1142021229838617/1205057443326659/f
Description:
Allows you to manage your private Duck addresses
Steps to test this PR:
Other tests
Demo:
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template