Manage Private Email Addresses #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/BrowserServicesKit/Email/EmailManager.swift
…vate-duck-address
|
A few changes to fix the reported issues:
|
|
As for the reported issue "3f": (Existing account being auto-updated when generating password), the behavior on Android is to create another account. While we cannot do that due to the unique username constraint, I'm no longer auto-updating data for those accounts, which should trigger a update dialog on submission. This is also covered by a unit test
|
amddg44
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
LGTM! This is a significant improvement to the logic around autosaving; great work @afterxleep 🎉
Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift
Outdated
Show resolved
Hide resolved
Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift
Outdated
Show resolved
Hide resolved
) Task/Issue URL: https://app.asana.com/0/414709148257752/1205091275850283/f Description: Allow to set internal user state in debug.
* replace assertion in assertObjectDeallocated with sigint * add different options to ensureObjectDeallocated; fix some warnings
Task/Issue URL: https://app.asana.com/0/0/1205093266805582/f Rework Sync initialization mechanism by moving sync data models initialization from DDGSync (where it was tied to account signup/login flow) to data models themselves. Sync Metadata is leveraged to store sync setup state per data model. Two values are possible: needs remote data fetch (a.k.a initial sync) or ready to sync. Decoupling account flow from data models initialization allows to initialize data models independently of user turning on sync, which is a requirement to support initial sync for new syncable models added with client app updates. Also DataProvider class has been added – it's a dedicated sync data providers superclass that also encapsulates common logic, making individual data providers simpler.
Task/Issue URL: https://app.asana.com/0/72649045549333/1203956617610891/f Tech Design URL: https://app.asana.com/0/481882893211075/1204384679803788/f Making Fire Window available to public # Conflicts: # Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift
Task/Issue URL: https://app.asana.com/0/0/1205119749390492/f Tech Design URL: CC: @Bunn @jotaemepereira Description: This PR extracts the reusable SecureVault logic out into a new SecureStorage module. This module is used by Autofill, and is usable by the client apps directly to implement secure storage on their own. The API for this new module matches the existing API as much as possible, and the implementation of the key/crypto providers is made easier by providing default implementations of the generic functions. Note that not all areas of the code have been renamed; for example, there is still a struct called SecureVaultModels which I would like to rename AutofillModels, but in this case this symbol is referenced over 600 times, so I plan to do this in a follow-up renaming PR to keep this PR as small as possible (it's already quite large). # Conflicts: # Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift # Tests/BrowserServicesKitTests/SecureVault/SecureVaultManagerTests.swift
Task/Issue URL: https://app.asana.com/0/414235014887631/1203017403159775/f iOS PR: duckduckgo/iOS#1862 macOS PR: duckduckgo/macos-browser#1388 Description: Class that aggregates detected Ad Attributions on a websites and stores that count over a certain time interval.
Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com>
* Use more swift concurrency in pinger tests * Remove dead code and duped tests
Task/Issue URL: https://app.asana.com/0/414235014887631/1205157723964854/f iOS PR: duckduckgo/iOS#1875 macOS PR: duckduckgo/macos-browser#1406 * os_log fixes * add log visibility modifier to interpolated os_log * fix os_log overloads
# Conflicts: # Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift
afterxleep
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 3, 2023
Task/Issue URL: https://app.asana.com/0/72649045549333/1204615490114675/f BSK PR: duckduckgo/BrowserServicesKit#396 **Description**: Enable/Disable Private Email Addresses from the Password management UI --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/72649045549333/1204615490114675/f
iOS PR: duckduckgo/iOS#1828
macOS PR: duckduckgo/macos-browser#1319
What kind of version bump will this require?: Minor
Optional:
Description:
Allows users to manage their Private Email addresses from the browser.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template