Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Private Email Addresses #396

Merged
merged 97 commits into from
Aug 3, 2023
Merged

Commits on Jun 2, 2023

  1. Configuration menu
    Copy the full SHA
    9f7e7ec View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Configuration menu
    Copy the full SHA
    930c3a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Configuration menu
    Copy the full SHA
    396a849 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3fb664c View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Return Email Alias Status

    afterxleep committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    62d3f30 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Merge branch 'main' into daniel/manage-private-duck-address

    # Conflicts:
    #	Sources/BrowserServicesKit/Email/EmailManager.swift
    afterxleep committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    025110b View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    134a7df View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Move endpoints to prod

    afterxleep committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    91b8677 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Update Login URL

    afterxleep committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a929ae4 View commit details
    Browse the repository at this point in the history
  2. Updated Service URL

    afterxleep committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    1c40295 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Fixed Tests

    afterxleep committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    83e082f View commit details
    Browse the repository at this point in the history
  2. Removed unnecesary tests

    afterxleep committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e1ebf2c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d44ec9f View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Configuration menu
    Copy the full SHA
    c27a6f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d986a0a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d8b5ad8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dd5b8cd View commit details
    Browse the repository at this point in the history
  5. Us Correct Autofill branch

    afterxleep committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    d775412 View commit details
    Browse the repository at this point in the history
  6. Account Saving Updates

    afterxleep committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    41c7f87 View commit details
    Browse the repository at this point in the history
  7. Updated more logic

    afterxleep committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    3fd5756 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Configuration menu
    Copy the full SHA
    b75647e View commit details
    Browse the repository at this point in the history
  2. Comment

    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    e71c932 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3868722 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8505bb8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e5dfdb2 View commit details
    Browse the repository at this point in the history
  6. Return Email Alias Status

    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    c4582b8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    889a306 View commit details
    Browse the repository at this point in the history
  8. Move endpoints to prod

    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    a0553ec View commit details
    Browse the repository at this point in the history
  9. Update Login URL

    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    677fb0e View commit details
    Browse the repository at this point in the history
  10. Updated Service URL

    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    8743bab View commit details
    Browse the repository at this point in the history
  11. Fixed Tests

    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    de32eba View commit details
    Browse the repository at this point in the history
  12. Removed unnecesary tests

    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    86e2898 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    88ed9eb View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0ebf977 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    1771177 View commit details
    Browse the repository at this point in the history
  16. Us Correct Autofill branch

    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    321f481 View commit details
    Browse the repository at this point in the history
  17. Account Saving Updates

    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    085c8cf View commit details
    Browse the repository at this point in the history
  18. Updated more logic

    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    982ce92 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    ef2ef58 View commit details
    Browse the repository at this point in the history
  20. Comment

    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    e44c9d7 View commit details
    Browse the repository at this point in the history
  21. Merge branch 'daniel/private-email-autofill' of github.com:duckduckgo…

    …/BrowserServicesKit into daniel/private-email-autofill
    afterxleep committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    436f299 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Configuration menu
    Copy the full SHA
    d2dfc7c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e9266e View commit details
    Browse the repository at this point in the history
  3. Removed unwanted tests

    afterxleep committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    b94c80d View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Remove unwanted code

    afterxleep committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    67ddb89 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6fa9477 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Configuration menu
    Copy the full SHA
    20d488c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    20015ec View commit details
    Browse the repository at this point in the history
  3. Remove comment

    afterxleep committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0080cc8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df6f7cf View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Email Alias update

    afterxleep committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    e3a3eef View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Configuration menu
    Copy the full SHA
    0083386 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Configuration menu
    Copy the full SHA
    9c257db View commit details
    Browse the repository at this point in the history
  2. Update Autofill branch

    afterxleep committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d6244aa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c9fcfe6 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Configuration menu
    Copy the full SHA
    ddd1af0 View commit details
    Browse the repository at this point in the history
  2. Added Test

    afterxleep committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7776896 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0a2508b View commit details
    Browse the repository at this point in the history
  4. Cleanup

    afterxleep committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    262c052 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Configuration menu
    Copy the full SHA
    6a57bea View commit details
    Browse the repository at this point in the history
  2. Comment

    afterxleep committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    76ea12c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Autosaving

    afterxleep committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    0ac444f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84e0baa View commit details
    Browse the repository at this point in the history
  3. Removed test

    afterxleep committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8bcff7e View commit details
    Browse the repository at this point in the history
  4. Merge branch 'main' into daniel/private-email-autofill

    # Conflicts:
    #	Package.swift
    afterxleep committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6471607 View commit details
    Browse the repository at this point in the history
  5. Fix conflicts

    afterxleep committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    c1e45d0 View commit details
    Browse the repository at this point in the history
  6. Fix tests

    afterxleep committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    e75398a View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    49ab364 View commit details
    Browse the repository at this point in the history
  2. Lowercase Emails (#424)

    Task/Issue URL: https://app.asana.com/0/0/1205091595242093/f
    What kind of version bump will this require?: Patch
    
    Description:
    Lowercases user input for private emails, so ecample@Duck.com and example@DuCK.com are treated as valid
    afterxleep authored Jul 19, 2023
    Configuration menu
    Copy the full SHA
    3a07261 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Update autosave logic to properly trust autogenerated fields from JS …

    …only on generation and not submission
    afterxleep committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a9c5365 View commit details
    Browse the repository at this point in the history
  2. Updated comment

    afterxleep committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    437ab74 View commit details
    Browse the repository at this point in the history
  3. Update Tests

    afterxleep committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f855183 View commit details
    Browse the repository at this point in the history
  4. Updated tests

    afterxleep committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    d0834e7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0b92c93 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Bump autofill to 8.0.0

    afterxleep committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    83ebb3c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Updated logic

    afterxleep committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    70466fd View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Configuration menu
    Copy the full SHA
    b93cf42 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    5f5af9c View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Configuration menu
    Copy the full SHA
    6b06eac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cec87f4 View commit details
    Browse the repository at this point in the history
  3. Updated tests for clarity

    afterxleep committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9047be0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    85067ae View commit details
    Browse the repository at this point in the history
  5. Updated Test

    afterxleep committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    83a1d2b View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Address PR feedback

    afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    cba2a98 View commit details
    Browse the repository at this point in the history
  2. Fix publisher, add option to override internal user state in debug (#422

    )
    
    Task/Issue URL: https://app.asana.com/0/414709148257752/1205091275850283/f
    
    Description:
    
    Allow to set internal user state in debug.
    bwaresiak authored and afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    8fad8f0 View commit details
    Browse the repository at this point in the history
  3. replace assertion in assertObjectDeallocated with sigint (#428)

    * replace assertion in assertObjectDeallocated with sigint
    
    * add different options to ensureObjectDeallocated; fix some warnings
    mallexxx authored and afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    d3e8c82 View commit details
    Browse the repository at this point in the history
  4. Add support for per-model Sync Data Providers initialization (#433)

    Task/Issue URL: https://app.asana.com/0/0/1205093266805582/f
    
    Rework Sync initialization mechanism by moving sync data models initialization from
    DDGSync (where it was tied to account signup/login flow) to data models themselves.
    Sync Metadata is leveraged to store sync setup state per data model. Two values are
    possible: needs remote data fetch (a.k.a initial sync) or ready to sync.
    Decoupling account flow from data models initialization allows to initialize data models
    independently of user turning on sync, which is a requirement to support initial sync
    for new syncable models added with client app updates.
    Also DataProvider class has been added – it's a dedicated sync data providers superclass
    that also encapsulates common logic, making individual data providers simpler.
    ayoy authored and afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    d5c6373 View commit details
    Browse the repository at this point in the history
  5. disable trailing_comma (#434)

    mallexxx authored and afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9f5fb53 View commit details
    Browse the repository at this point in the history
  6. Fire Window (#420)

    Task/Issue URL: https://app.asana.com/0/72649045549333/1203956617610891/f
    Tech Design URL: https://app.asana.com/0/481882893211075/1204384679803788/f
    
    Making Fire Window available to public
    
    # Conflicts:
    #	Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift
    tomasstrba authored and afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9a0e112 View commit details
    Browse the repository at this point in the history
  7. Extract SecureVault code into SecureStorage module (#430)

    Task/Issue URL: https://app.asana.com/0/0/1205119749390492/f
    Tech Design URL:
    CC: @Bunn @jotaemepereira
    
    Description:
    
    This PR extracts the reusable SecureVault logic out into a new SecureStorage module.
    
    This module is used by Autofill, and is usable by the client apps directly to implement secure storage on their own. The API for this new module matches the existing API as much as possible, and the implementation of the key/crypto providers is made easier by providing default implementations of the generic functions.
    
    Note that not all areas of the code have been renamed; for example, there is still a struct called SecureVaultModels which I would like to rename AutofillModels, but in this case this symbol is referenced over 600 times, so I plan to do this in a follow-up renaming PR to keep this PR as small as possible (it's already quite large).
    # Conflicts:
    #	Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift
    #	Tests/BrowserServicesKitTests/SecureVault/SecureVaultManagerTests.swift
    samsymons authored and afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ba46fc9 View commit details
    Browse the repository at this point in the history
  8. Attribution pixel (#432)

    Task/Issue URL: https://app.asana.com/0/414235014887631/1203017403159775/f
    iOS PR: duckduckgo/iOS#1862
    macOS PR: duckduckgo/macos-browser#1388
    
    Description:
    Class that aggregates detected Ad Attributions on a websites and stores that count over a certain time interval.
    jaceklyp authored and afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    89ec4fb View commit details
    Browse the repository at this point in the history
  9. bump CSS to 4.30.0 for messageHandlers fix (#439)

    Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com>
    2 people authored and afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    a6e1ab8 View commit details
    Browse the repository at this point in the history
  10. De-flake pinger tests (#436)

    * Use more swift concurrency in pinger tests
    
    * Remove dead code and duped tests
    graeme authored and afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    36d2840 View commit details
    Browse the repository at this point in the history
  11. os_log fixes (#437)

    Task/Issue URL: https://app.asana.com/0/414235014887631/1205157723964854/f
    iOS PR: duckduckgo/iOS#1875
    macOS PR: duckduckgo/macos-browser#1406
    
    * os_log fixes
    
    * add log visibility modifier to interpolated os_log
    
    * fix os_log overloads
    mallexxx authored and afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    7c5a0bc View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a5d33aa View commit details
    Browse the repository at this point in the history
  13. Merge branch 'main' into daniel/private-email-autofill

    # Conflicts:
    #	Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift
    afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5206c6d View commit details
    Browse the repository at this point in the history
  14. Revert "Merge branch 'main' into daniel/private-email-autofill"

    This reverts commit 5206c6d, reversing
    changes made to a5d33aa.
    afterxleep committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    80e0d6f View commit details
    Browse the repository at this point in the history