Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime config support to email in-context signup webview #2621

Merged

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Mar 21, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1206881234663275/f
Tech Design URL:
CC:

Description:
Implements the required getRuntimeConfiguration for autofill script for the in-context email webview. Also adds Autofill debug menu option to reset the InstallDate to 0

Steps to test this PR:

  1. If signed in to Email Protection, sign out first (Settings > Email Protection > scroll down to Sign Out)

  2. Visit https://fill.dev/form/registration-email and tap the grey dax icon to trigger the in-context signup flow.
    Note: if you don't see the grey dax icon in the email field, go to Settings > All debug options > Autofill Settings and tap the two Reset rows in the Email Protection and reload the webpage
    image

  3. Follow the sign up flow to create a new duck address and confirm it completes successfully, prompting to fill your newly created address or a private duck address like so:
    image

  4. Sign out of email protection and tap the Reset Email Protection InContext Signup Prompt in debug settings

  5. Reload the webpage and tap the grey duck icon again

  6. This time follow the sign-in flow and confirm it completes successfully also

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 changed the base branch from main to update-bsk-with-autofill-10.2.0 March 21, 2024 10:51
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated and LGTM 🚀

@amddg44 amddg44 merged commit 22aa532 into update-bsk-with-autofill-10.2.0 Mar 21, 2024
18 checks passed
@amddg44 amddg44 deleted the anya/email-incontect-runtime-config branch March 21, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants