-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BSK with autofill 10.2.0 #2590
Conversation
@GioSensation @shakyShane it looks like there is an issue with this autofill release and email incontext signup on iOS. EmailManager.autofillUserScriptDidCompleteInContextSignup is no longer firing, so the final stage of the email sign-up and sign-in flows are broken with the Email Protection screen never getting dismissed. I checked and there were no errors in the console, it's like a message handler just stopped firing or was possibly removed? Let me know if I can do anything to help Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-20.at.17.11.15.mp4Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-20.at.17.03.06.mp4 |
FYI, we've noticed that the native side is not sending the proper |
…ill-10.2.0 # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Thanks both! The issue was indeed a runtime config support issue in the in-context webview; i've opened a PR with a fix (and I also added a debug option to reset the days since installed to 0 for ease of testing the incontext signup flow) |
Thanks @GioSensation that is definitely inspiring! 😄 |
Task/Issue URL: https://app.asana.com/0/414235014887631/1206881234663275/f Tech Design URL: CC: Description: Implements the required getRuntimeConfiguration for autofill script for the in-context email webview. Also adds Autofill debug menu option to reset the InstallDate to 0
…ill-10.2.0 # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Task/Issue URL: https://app.asana.com/0/1206839421155398/1206839421155398
Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/10.2.0
BSK PR: duckduckgo/BrowserServicesKit#723
Description
Updates Autofill to version 10.2.0.
Autofill 10.2.0 release notes
What's Changed
New Contributors
Full Changelog: duckduckgo/duckduckgo-autofill@10.1.0...10.2.0
Steps to test
This release has been tested during autofill development. For smoke test steps see this task.