Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BSK with autofill 10.2.0 #2590

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Conversation

daxmobile
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1206839421155398/1206839421155398
Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/10.2.0
BSK PR: duckduckgo/BrowserServicesKit#723

Description

Updates Autofill to version 10.2.0.

Autofill 10.2.0 release notes

What's Changed

New Contributors

Full Changelog: duckduckgo/duckduckgo-autofill@10.1.0...10.2.0

Steps to test

This release has been tested during autofill development. For smoke test steps see this task.

@amddg44
Copy link
Contributor

amddg44 commented Mar 20, 2024

@GioSensation @shakyShane it looks like there is an issue with this autofill release and email incontext signup on iOS. EmailManager.autofillUserScriptDidCompleteInContextSignup is no longer firing, so the final stage of the email sign-up and sign-in flows are broken with the Email Protection screen never getting dismissed.

I checked and there were no errors in the console, it's like a message handler just stopped firing or was possibly removed? Let me know if I can do anything to help

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-20.at.17.11.15.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-20.at.17.03.06.mp4

@GioSensation
Copy link
Member

FYI, we've noticed that the native side is not sending the proper getRuntimeConfiguration in the in-context signup webview. The PR where we removed isEnabled checks is probably relying on the runtime config being present and correct, and this may cause the communication to start failing. Anya will look into this.

…ill-10.2.0

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
@amddg44
Copy link
Contributor

amddg44 commented Mar 21, 2024

Thanks both! The issue was indeed a runtime config support issue in the in-context webview; i've opened a PR with a fix (and I also added a debug option to reset the days since installed to 0 for ease of testing the incontext signup flow)
image

@GioSensation
Copy link
Member

Nice! Thanks, Anya! FWIW, this is the options we have for email protection on Android, in case you need further inspiration.
CleanShot 2024-03-21 at 12 13 54

@amddg44
Copy link
Contributor

amddg44 commented Mar 21, 2024

Thanks @GioSensation that is definitely inspiring! 😄

Task/Issue URL: https://app.asana.com/0/414235014887631/1206881234663275/f
Tech Design URL:
CC:

Description:
Implements the required getRuntimeConfiguration for autofill script for the in-context email webview. Also adds Autofill debug menu option to reset the InstallDate to 0
…ill-10.2.0

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@amddg44 amddg44 merged commit 066e677 into main Mar 21, 2024
13 checks passed
@amddg44 amddg44 deleted the update-bsk-with-autofill-10.2.0 branch March 21, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants