separate 'third party provider' feature

[shakyShane]

Reviewer: @GioSensation
Asana:

Description

Just moving the code for the 3rd party provider into a separate file - it operates exactly the same but is now no-longer spread across 3 different files.

We should try to avoid growing the size of the base interface in the name of code-share etc. We can apply composition + dependency injection to get the exact same behaviour.

We did this recently with initFormSubmissionsApi and we should continue the trend of having features self-contained - we can still pass in the device and do whatever we need, but it prevents a feature like this from becoming spread across multiple files.

Overview, before

class InterfacePrototype {
    askToUnlockProvider() { /* snip */ }
    providerStatusUpdated() { /* snip */ }
}

class AppleDeviceInterface extends InterfacePrototype {
    async addDeviceListeners () { /* snip */ }
    async _pollForUpdatesToCredentialsProvider () { /* snip */ }
}

class AppleOverlayDeviceInterface extends InterfacePrototype {
    async askToUnlockProvider () { /* snip */ }

    providerStatusUpdated (data) { /* snip */ }
}

Overview, after

export class ThirdPartyProvider {
    constructor(device) { /* snip */ }
    init () { /* snip */ }
    async askToUnlockProvider () { /* snip */ }
    async _pollForUpdatesToCredentialsProvider () { /* snip */ }
    providerStatusUpdated (data) { /* snip */ }
}

Steps to test

@GioSensation This passes all of your existing integration tests (thanks for adding those!) - which makes sense though because all I've done is remove the methods from the interfaces :)

[github-actions]

Note: Password rules outdated

inntopia.travel not present in current
	rules: minlength: 7; maxlength: 19; required: digit; allowed: upper,lower,[-];

You can update the rules with the following command

cd packages/password && npm run rules:update

Once you've updated the rules, re-run the build from the root with npm run build and then commit all changes.

[GioSensation]

I finally got around to merging this. Thanks so much for opening it, @shakyShane. I will use it as an example in the docs. 💪