Fix regression #549
Merged
Fix regression #549
+92
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
GioSensation
commented
Apr 9, 2024
| openManageCreditCards () { | ||
| return this.deviceApi.notify(createNotification('pmHandlerOpenManageCreditCards')) | ||
| } | ||
|
|
There was a problem hiding this comment.
We'd removed these in #252 but never added them back 🙃.
GioSensation
commented
Apr 9, 2024
| @@ -401,6 +412,7 @@ test.describe('Auto-fill a login form on macOS', () => { | |||
| if (expectedLabel) { | |||
| await overlay.clickButtonWithText(expectedLabel) | |||
| await overlay.assertCloseAutofillParent() | |||
| await overlay.assertCallHappenedTimes(expectedCall, 1) | |||
There was a problem hiding this comment.
Asserting the call will prevent regressions in the future.
shakyShane
approved these changes
Apr 9, 2024
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane
Asana: https://app.asana.com/0/1203822806345703/1207033630521713/f
Description
The manage button regressed in #252. Fixed now and improved the tests.
Steps to test
Integration tests added + tested in browser.