Fix regression

integration-test/helpers/pages/overlayPage.js

@@ -52,6 +52,11 @@ export function overlayPage (page) {
  const button = await page.locator(`button:has-text("${text}")`)
  await expect(button).toHaveCount(0)
  }
+
+ async assertCallHappenedTimes (callName, times) {
+ const calls = await mockedCalls(page, {names: [callName]})
+ expect(calls.length).toBe(times)
+ }
  }
 
  return new OverlayPage()

integration-test/tests/login-form.macos.spec.js

@@ -355,18 +355,21 @@ test.describe('Auto-fill a login form on macOS', () => {
  username: personalAddress,
  password
  },
- expectedLabel: 'Manage passwords…'
+ expectedLabel: 'Manage passwords…',
+ expectedCall: 'pmHandlerOpenManagePasswords'
  },
  {
  description: 'with identities',
  identity: constants.fields.identity,
- expectedLabel: 'Manage identities…'
+ expectedLabel: 'Manage identities…',
+ expectedCall: 'pmHandlerOpenManageIdentities'
  },
  {
  description: 'with identities and Email Protection',
  identity: constants.fields.identity,
  emailProtection: {personalAddress, privateAddress},
- expectedLabel: 'Manage identities…'
+ expectedLabel: 'Manage identities…',
+ expectedCall: 'pmHandlerOpenManageIdentities'
  },
  {
  description: 'with Email Protection and no identities should not show',
@@ -376,12 +379,20 @@ test.describe('Auto-fill a login form on macOS', () => {
  {
  description: 'with credit card',
  creditCard: constants.fields.creditCard,
- expectedLabel: 'Manage credit cards…'
+ expectedLabel: 'Manage credit cards…',
+ expectedCall: 'pmHandlerOpenManageCreditCards'
  }
  ]
 
  for (const testCase of testCases) {
- const {description, credentials, identity, creditCard, expectedLabel} = testCase
+ const {
+ description,
+ credentials,
+ identity,
+ creditCard,
+ expectedLabel,
+ expectedCall
+ } = testCase
  test(description, async ({page}) => {
  await forwardConsoleMessages(page)
  await createWebkitMocks()
@@ -401,6 +412,7 @@ test.describe('Auto-fill a login form on macOS', () => {
  if (expectedLabel) {
  await overlay.clickButtonWithText(expectedLabel)
  await overlay.assertCloseAutofillParent()
+ await overlay.assertCallHappenedTimes(expectedCall, 1)
  } else {
  await overlay.assertTextNotPresent('Manage')
  }

src/DeviceInterface/AppleDeviceInterface.js

@@ -217,6 +217,20 @@ class AppleDeviceInterface extends InterfacePrototype {
  return this.deviceApi.notify(createNotification('pmHandlerOpenManagePasswords'))
  }
 
+ /**
+ * Opens the native UI for managing identities
+ */
+ openManageIdentities () {
+ return this.deviceApi.notify(createNotification('pmHandlerOpenManageIdentities'))
+ }
+
+ /**
+ * Opens the native UI for managing credit cards
+ */
+ openManageCreditCards () {
+ return this.deviceApi.notify(createNotification('pmHandlerOpenManageCreditCards'))
+ }
+
  /**
  * Gets a single identity obj once the user requests it
  * @param {IdentityObject['id']} id