update email autofill #113
Conversation
…eceived (fixes web view being accessed from not-main thread)
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
| kind = revision; | ||
| revision = d8d6579ff2b1e78f5a2e264b4a9a2cf77701e7eb; | ||
| branch = main; | ||
| kind = branch; |
There was a problem hiding this comment.
@samsymons I had to do this because "GRDB" is considered unstable. I guess because we are referencing the revision. I know you made a change there recently for a similar reason. Did I mess something up here?
I am thinking though we can just start versioning our fork of GRDB. Maybe tag it as the next major version from where we forked. WDYT?
There was a problem hiding this comment.
@brindy Yeah, this one has hit me as well. Originally, the BSK Package manifest was pointing to the GRDB branch, which made sense to me why Swift PM considered it unstable: if a new commit is pushed to that branch, the same BSK version would fetch it and potentially break.
I changed it to point at a specific GRDB commit instead, thinking that it would then consider it stable. The commit won't change, and new commits pointing to that branch won't be able to break anything that uses BSK. But, nope, it considers that unstable too (which I consider to be a bug, unless I'm missing something).
Long story short, yeah we should version the GRDB fork and then update BSK to use that version. After that, we can start using BSK's version tags again.
There was a problem hiding this comment.
Cool, thanks @samsymons
I'd like to get this on develop so it appears in a release soon then I can follow up with that, if that's OK?
There was a problem hiding this comment.
Updated it to point at a commit ref of BSK
# By Tomas Strba (4) and others # Via GitHub * develop: Update the Chrome user agent (#122) TabViewModel released immediately from TabCollectionViewModel after its tab is closed (#118) User agent updated (#117) History Storage - Please do not merge (#108) use the temporary unprotected sites list and update the frequency to 30 minutes (#114) update email autofill (#113) Version 0.6.16 Force the content blocking rules publisher onto the main thread. (#112) Update to BrowserServicesKit 1.1.1 (#111) Zoom menu items; Menu Items validation (#105) check file headers programatically (#110) Fixed up filenames in file headers (#109) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Bookmarks/Services/Bookmark.xcdatamodeld/Bookmark.xcdatamodel/contents # Unit Tests/Bookmarks/Services/LocalBookmarkStoreTests.swift # Unit Tests/FileSystem/CoreDataEncryptionTests.swift
Task/Issue URL: https://app.asana.com/0/392891325557410/1200275136285356
Tech Design URL:
CC:
Description:
Updates the email product to show both their personal address and an alias when autofilling.
Note that BSK is set to
mainjust now. This is because setting a version creates a compile error due to the way we are linking to GRDB. I will fix this separately.Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM