Memory leak fixed #118
Merged
Memory leak fixed #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
approved these changes
May 20, 2021
samsymons
added a commit
that referenced
this pull request
May 26, 2021
# By Tomas Strba (4) and others # Via GitHub * develop: Update the Chrome user agent (#122) TabViewModel released immediately from TabCollectionViewModel after its tab is closed (#118) User agent updated (#117) History Storage - Please do not merge (#108) use the temporary unprotected sites list and update the frequency to 30 minutes (#114) update email autofill (#113) Version 0.6.16 Force the content blocking rules publisher onto the main thread. (#112) Update to BrowserServicesKit 1.1.1 (#111) Zoom menu items; Menu Items validation (#105) check file headers programatically (#110) Fixed up filenames in file headers (#109) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Bookmarks/Services/Bookmark.xcdatamodeld/Bookmark.xcdatamodel/contents # Unit Tests/Bookmarks/Services/LocalBookmarkStoreTests.swift # Unit Tests/FileSystem/CoreDataEncryptionTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1200300006780048/f
CC:
Description:
TabViewModel released immediately from TabCollectionViewModel after its tab is closed. Prevents video/audio from playing after the closing.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM