This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Disables a flaky test #1541
Closed
Disables a flaky test #1541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@diegoreymendez please see #1538 |
Contributor
Author
|
@mallexxx - Can you expand on the relationship between the two PRs? The relationship isn't immediately clear to me. |
afterxleep
approved these changes
Aug 24, 2023
Collaborator
|
@diegoreymendez, autoconsent tests were fixed in #1473 and SearchNonexistentDomainTests were fixed in #1538, I suggest closing this PR |
Contributor
Author
|
Yeah, I was waiting to see if that was going to be the case after our chat. Thanks for the update @mallexxx. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205237866452338/1205315743950956/f
Other related tasks: https://app.asana.com/0/1205237866452338/1205344340378907/f
Tech Design URL:
CC:
Description:
Disables a flaky test.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation