This repository was archived by the owner on Feb 24, 2025. It is now read-only.
NetP onboarding: changes a color and updates some assets #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Aug 28, 2023
# By Diego Rey Mendez (3) and others # Via GitHub * develop: NetP menu no longer opening (#1552) Adjusts the NetP onboarding bg color (#1550) Save/edit always the same profile (#1545) Enable autoconsent tests for cosmetic rules (#1473) Title doubleclick action (#1549) NetP onboarding: changes a color and updates some assets (#1547) La/disable ctl for catalina (#1462) fix tab content disappearance due to wrong pinned tab index selection (#1532) disable flaky test (#1546) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205330979601115/f
Description
Updates some assets according to the design requests in the tasks above.
But in case you want to see more, here's the figma link: https://www.figma.com/file/nscneJs8hvI6j2m24AFTsD/Setup-steps-macOS-Network-Protection?node-id=176%3A45346&mode=dev
Testing
I'd say it doesn't make sense to review the design as the designer will approve the changes so it's enough for you to make sure nothing is wrong in terms of code or breakage.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation