La/disable ctl for catalina

[ladamski]

Task/Issue URL: https://app.asana.com/0/1201037661562251/1205194870935032/f
Tech Design URL:
CC:

Description:
Disable CTL for Catalina (and earlier)
Steps to test this PR:
Visit https://privacy-test-pages.glitch.me/privacy-protections/click-to-load/

1. For MacOS 11+, CTL should work as normal
2. For Catalina, it should be disabled and all FB buttons and elements should load (for SDK and iframe elements)
3. Toggle protections in each and ensure behavior is as expected (MacOS 11+ CTL is enabled and disabled, for Catalina it remains disabled regardless)

---

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

[samsymons]

@tomasstrba How far away is the macOS Catalina removal work? We might be able to supersede this PR with that

[tomasstrba]

@ladamski, I am getting syntax and type errors in the Console for changes suggested for Catalina. Can you reproduce it?

[ladamski]

The type error is expected as we're passing in an empty FB config so it doesn't parse gracefully. Since its just a quick fix for Catalina I think that's ok, since the content script just bails (and it shouldn't be happening for non-Catalina users).

The syntax error I can't reproduce. I'm actually not sure what sdk.js is. Is this on the stock branch or one you tweaked to test? Or which page are you testing on?

@ladamski, I am getting syntax and type errors in the Console for changes suggested for Catalina. Can you reproduce it?

[tomasstrba]

Lucas, I investigated the syntax error and found out it was the autoconsent script. We had an issue with it last week which probably still exist in this branch. After merging develop into the branch, the syntax error is no longer there.

LGTM! ✅