This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Popovers positioning #1574
Merged
Popovers positioning #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
approved these changes
Sep 1, 2023
Contributor
brindy
left a comment
brindy
left a comment
There was a problem hiding this comment.
Just a couple of comments. If there's nothing you can do about the fire button popover in full screen then will have to see it'll pass the ship review.
| private func setupFireButton() { | ||
| fireButton.toolTip = UserText.clearBrowsingHistoryTooltip | ||
| fireButton.animationNames = MouseOverAnimationButton.AnimationNames(aqua: "flame-mouse-over", dark: "dark-flame-mouse-over") | ||
| fireButton.sendAction(on: .leftMouseDown) |
Contributor
There was a problem hiding this comment.
What's this doing? Didn't seem to have any affect when I commented it out.
Collaborator
Author
There was a problem hiding this comment.
it‘s making the popover appear on mouse-down, not on click, it‘s used for other popovers too
brindy
reviewed
Sep 4, 2023
brindy
approved these changes
Sep 4, 2023
Contributor
brindy
left a comment
brindy
left a comment
There was a problem hiding this comment.
Just a print statement to remove, but otherwise LGTM
samsymons
added a commit
that referenced
this pull request
Sep 4, 2023
# By Alexey Martemyanov (5) and others # Via GitHub (1) and Tomas Strba (1) * develop: DBP Debug UI (#1587) Bump version to 1.55.0 (57) Update embedded files Auto start DBP scheduler (#1586) Add broker updater mechanism (#1580) Update develop with Bitwarden fix (#1585) fix outlook popups loading; set popup window mode to match Safari (#1564) remove AppActivityMonitor and related unused code (#1582) Popovers positioning (#1574) Version 1.54.1 xcode 15 synthesized color constants fixes (#1583) Fixes issue with password saving when using Bitwarden (#1584) Remove the incremental test pixel sender (#1578) Implement waitlistBetaActive logic (without actually resetting) (#1562) Lock Form fill when autofill is locked (#1559) show alert when user tries to open file in AppStore version (#1494) DBP UI Middleware (#1553) Dashboard & Profile Creation (#1567) roll out the bookmarks bar experiment (#1572) Open duck player for youtube same-document navigation (#1560) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Common/Localizables/UserText.swift # DuckDuckGo/NavigationBar/PinningManager.swift # DuckDuckGo/NavigationBar/View/NavigationBarViewController.swift # DuckDuckGo/Waitlist/NetworkProtectionFeatureVisibility.swift # UnitTests/Menus/MoreOptionsMenuTests.swift
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202217488822824/f
Figma: https://www.figma.com/file/pJbEb2nC4jwXlToaV0xwGD/Time-boxed-UI-polish-round-(2022-09)?type=design&node-id=48-15266&mode=design&viewport=-2903%2C2125%2C1.15&t=VC4yzgdLvv3RaUhD-0
Description:
!! it seems the approach doesn‘t work in latest Sonoma beta: https://app.asana.com/0/0/1205377179358269/1205391501334690/f - I‘m downloading it to inspect
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation