This repository was archived by the owner on Feb 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Add broker updater mechanism #1580
Merged
jotaemepereira
merged 1 commit into
develop
from
juan/dbp/add-mechanism-to-handle-broker-updates
Sep 4, 2023
Merged
Add broker updater mechanism #1580
jotaemepereira
merged 1 commit into
develop
from
juan/dbp/add-mechanism-to-handle-broker-updates
Sep 4, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
500db37 to
a001df9
Compare
Bunn
reviewed
Sep 4, 2023
...erProtection/Sources/DataBrokerProtection/Operations/DataBrokerProtectionBrokerUpdater.swift
Show resolved
Hide resolved
Bunn
reviewed
Sep 4, 2023
...erProtection/Sources/DataBrokerProtection/Operations/DataBrokerProtectionBrokerUpdater.swift
Outdated
Show resolved
Hide resolved
Bunn
reviewed
Sep 4, 2023
...erProtection/Sources/DataBrokerProtection/Operations/DataBrokerProtectionBrokerUpdater.swift
Outdated
Show resolved
Hide resolved
Bunn
reviewed
Sep 4, 2023
...erProtection/Sources/DataBrokerProtection/Operations/DataBrokerProtectionBrokerUpdater.swift
Outdated
Show resolved
Hide resolved
Bunn
approved these changes
Sep 4, 2023
Collaborator
Bunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, left some comments there, none are blockers, but the dependency injection ones are probably good ones to tackle now, but I'll leave it to you.
Nice job!
a001df9 to
4948676
Compare
4948676 to
118d3a9
Compare
samsymons
added a commit
that referenced
this pull request
Sep 4, 2023
# By Alexey Martemyanov (5) and others # Via GitHub (1) and Tomas Strba (1) * develop: DBP Debug UI (#1587) Bump version to 1.55.0 (57) Update embedded files Auto start DBP scheduler (#1586) Add broker updater mechanism (#1580) Update develop with Bitwarden fix (#1585) fix outlook popups loading; set popup window mode to match Safari (#1564) remove AppActivityMonitor and related unused code (#1582) Popovers positioning (#1574) Version 1.54.1 xcode 15 synthesized color constants fixes (#1583) Fixes issue with password saving when using Bitwarden (#1584) Remove the incremental test pixel sender (#1578) Implement waitlistBetaActive logic (without actually resetting) (#1562) Lock Form fill when autofill is locked (#1559) show alert when user tries to open file in AppStore version (#1494) DBP UI Middleware (#1553) Dashboard & Profile Creation (#1567) roll out the bookmarks bar experiment (#1572) Open duck player for youtube same-document navigation (#1560) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Common/Localizables/UserText.swift # DuckDuckGo/NavigationBar/PinningManager.swift # DuckDuckGo/NavigationBar/View/NavigationBarViewController.swift # DuckDuckGo/Waitlist/NetworkProtectionFeatureVisibility.swift # UnitTests/Menus/MoreOptionsMenuTests.swift
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
https://app.asana.com/0/1203581873609357/1205378118665592/f
Description
This adds the following changes:
When inserting/editing a profile
Before the scheduler starts running the operations
Here, we check for updates to the broker's list or new ones added. Because this operation could have an impact on performance (it has to go through the JSON files, decode them, and compare them to the database ones) it will run if it didn’t run in the last 24 hours (this constant can be changed)
Steps to test
Scenario 1 - User inserts a new profile
Vault.db)Scenario 2 - User edits a profile
Scenario 3 - There are updates to a broker JSON file
UserDefaultsby runningdefaults com.duckduckgo.macos.browser.debugScenario 4 - There is a new JSON file
UserDefaultsby runningdefaults com.duckduckgo.macos.browser.debug