Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for DBP open button #2586

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Update copy for DBP open button #2586

merged 2 commits into from
Apr 11, 2024

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Apr 9, 2024

Task/Issue URL: https://app.asana.com/0/1204167627774280/1207034788876871/f

Description:
Update copy for DBP open button

Steps to test this PR:

  1. Open Privacy Pro settings page
  2. Check if under Personal Information Removal it says "Open" instead of "Get Started"

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Apr 9, 2024
@Bunn Bunn requested a review from jotaemepereira April 9, 2024 21:43
@Bunn Bunn removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Apr 9, 2024
Copy link
Collaborator

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Bunn Bunn merged commit bf6d92e into main Apr 11, 2024
23 of 25 checks passed
@Bunn Bunn deleted the bunn/dbp/change-copy branch April 11, 2024 10:09
samsymons added a commit that referenced this pull request Apr 12, 2024
# By Dax the Duck (10) and others
# Via GitHub (6) and others
* main: (40 commits)
  Bump version to 1.83.0 (160)
  macOS VPN: Ask users to reboot if system extension was not uninstalled (#2603)
  macOS VPN: Ask users to reboot if system extension was not uninstalled (#2603)
  Fix popover not displayed reliably when VPN shortcut is unpinned (#2606)
  Automatically mark / close stale PRs (#2596)
  Update copy for DBP open button (#2586)
  Bump version to 1.83.0 (159)
  [Release PR] Fix lottie high Windowserver load (#2598)
  Bump version to 1.83.0 (158)
  BSK release 133.1.0 (#2597)
  Fix VPN bug: Nearest city breaks register requests (#2589)
  Fix lottie high Windowserver load (#2595)
  drop Downloads storyboard (#2556)
  Disable directory download (#2585)
  Add supported document types (#2581)
  Allow choosing downloads location in App Store builds (#2532)
  Fix Open Downloads not working (#2576)
  Update Privacy Dashboard URL on navigation commit (#2583)
  Percent-decode download filenames (#2584)
  Bump version to 1.83.0 (157)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants