macOS VPN: Ask users to reboot if system extension was not uninstalled #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
commented
Apr 11, 2024
| @@ -408,7 +407,8 @@ enum NetworkProtectionPixelEvent: PixelKitEventV2 { | |||
| .networkProtectionClientFailedToParseRedeemResponse(let error), | |||
| .networkProtectionWireguardErrorCannotSetNetworkSettings(let error), | |||
| .networkProtectionRekeyFailure(let error), | |||
| .networkProtectionUnhandledError(_, _, let error): | |||
| .networkProtectionUnhandledError(_, _, let error), | |||
| .networkProtectionSystemExtensionActivationFailure(let error): | |||
There was a problem hiding this comment.
Restoring errors for this pixel.
diegoreymendez
commented
Apr 11, 2024
| @@ -54,7 +54,7 @@ extension NetworkExtensionController { | |||
|
|
|||
| NetworkProtectionLastVersionRunStore(userDefaults: defaults).lastExtensionVersionRun = extensionVersion | |||
|
|
|||
| try? await Task.sleep(nanoseconds: 300 * NSEC_PER_MSEC) | |||
| try await Task.sleep(nanoseconds: 300 * NSEC_PER_MSEC) | |||
There was a problem hiding this comment.
These errors should not be ignored as they're used to cancel tasks.
samsymons
approved these changes
Apr 11, 2024
diegoreymendez
deleted the
diego/ask-user-to-reboot-if-system-extension-requires-it
branch
diegoreymendez
added a commit
that referenced
this pull request
Apr 11, 2024
#2603) Task/Issue URL: https://app.asana.com/0/1199230911884351/1207056555335340/f ## Description We now ask again users to reboot if macOS requires it to complete installation of the system extension.
samsymons
added a commit
that referenced
this pull request
Apr 12, 2024
# By Dax the Duck (10) and others # Via GitHub (6) and others * main: (40 commits) Bump version to 1.83.0 (160) macOS VPN: Ask users to reboot if system extension was not uninstalled (#2603) macOS VPN: Ask users to reboot if system extension was not uninstalled (#2603) Fix popover not displayed reliably when VPN shortcut is unpinned (#2606) Automatically mark / close stale PRs (#2596) Update copy for DBP open button (#2586) Bump version to 1.83.0 (159) [Release PR] Fix lottie high Windowserver load (#2598) Bump version to 1.83.0 (158) BSK release 133.1.0 (#2597) Fix VPN bug: Nearest city breaks register requests (#2589) Fix lottie high Windowserver load (#2595) drop Downloads storyboard (#2556) Disable directory download (#2585) Add supported document types (#2581) Allow choosing downloads location in App Store builds (#2532) Fix Open Downloads not working (#2576) Update Privacy Dashboard URL on navigation commit (#2583) Percent-decode download filenames (#2584) Bump version to 1.83.0 (157) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207056555335340/f
Description
We now ask again users to reboot if macOS requires it to complete installation of the system extension.
Testing
Try the VPN normally. I don't know of a way to enforce this error to come up, so it's mostly about reviewing the code changes.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation