Migrate asana-extract-task-id GHA action to a fastlane plugin #3145

ayoy · 2024-08-25T21:15:43Z

Task/Issue URL: https://app.asana.com/0/1203301625297703/1208137627434482/f

Description:
This change introduces ddg_apple_automation fastlane plugin and its first action,
for extracting task ID from Asana task URL. Fastlane setup step was added to all
workflows, GHA action calls were replaced by fastlane action calls,
outputs were renamed to match action output name and old GHA action was removed.

Steps to test this PR:

Consult the implementation of the fastlane action and related unit tests. Note the usage of GitHubActionsHelper to set a GHA output when the action is run in CI.
Set up fastlane locally:

$ bundle install
$ fastlane install_plugins

Run the action locally and confirm that it extracts task ID, e.g:

$ bundle exec fastlane run asana_extract_task_id task_url:https://app.asana.com/0/1201621708115095/1208137627434473/f

Verify that this workflow completed successfully and uploaded a DMG to a task for which the ID was extracted using fastlane action.
Sanity-check changes to other workflows, especially to verify that extracted task ID is used in other steps of affected workflows under a new name (asana_task_id).

Definition of Done:

Does this PR satisfy our Definition of Done?

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

ayoy · 2024-08-25T21:22:08Z

.github/workflows/build_appstore.yml

@@ -102,9 +105,6 @@ jobs:
    - name: Select Xcode
      run: sudo xcode-select -s /Applications/Xcode_$(<.xcode-version).app/Contents/Developer

-    - name: Prepare fastlane


If a fastlane step existed in a workflow, I've now moved it to the next step after code checkout – in case we add more fastlane-dependent steps later.

ayoy · 2024-08-25T21:24:19Z

.github/workflows/build_notarized.yml

@@ -222,13 +225,6 @@ jobs:
        name: DuckDuckGo-${{ env.release-type }}-dSYM-${{ env.app-version }}
        path: ${{ github.workspace }}/release/${{ steps.set-outputs.outputs.dsym-name }}

-    - name: Extract Asana Task ID


This had no effect, as it turned out. The output wasn't used in any further step, nor is it defined as one of the outputs of the entire job.

This job is optionally followed by create-dmg job which calls that action on its own.

ayoy · 2024-08-25T21:24:43Z

.github/workflows/build_notarized.yml

+          Gemfile
+          Gemfile.lock
+          fastlane


These files are needed in every sparse checkout for fastlane to work, obviously.

alessandroboron · 2024-08-26T04:33:11Z

Gemfile

@@ -2,3 +2,6 @@ source 'https://rubygems.org'

 gem 'fastlane', '2.222.0'


Should we set the same version of Ruby for everyone?

I wonder if not setting this will cause Gemfile.lock to change due to Ruby version installed on the machine.

Good point! I'll make a task for it.

alessandroboron

This works as expected! Also the sanity check seems to be good, all the workflow changed use asana_task_id! 💪

I’ll merge it.

…iption * main: Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145) Fix address bar queries when doing math expressions (#3130)

Task/Issue URL: https://app.asana.com/0/1203301625297703/1208137627434482/f **Description**: This change introduces ddg_apple_automation fastlane plugin and its first action, for extracting task ID from Asana task URL. Fastlane setup step was added to all workflows, GHA action calls were replaced by fastlane action calls, outputs were renamed to match action output name and old GHA action was removed.

# By Dax the Duck (3) and others # Via Dominik Kapusta (2) and GitHub (2) * main: Unified feedback form for Privacy Pro (#3058) Fix state restoration after app termination (#3127) Bump Submodules/privacy-reference-tests from `afb4f61` to `6133e7d` (#3148) Bump version to 1.104.0 (250) Set marketing version to 1.104.0 Update embedded files Freemium PIR - Add Desktop RMF Attribute (#3146) Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145) Add missing secrets to publish_dmg_release.yml Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145) Fix address bar queries when doing math expressions (#3130) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

…iption * main: Add error pixels for Subscription keychain access errors (#3147) onboarding dax dialogs (#3149) Logging refactoring phase #2 (#3154) Move WireGuard dependency to VPN extensions (#3144) Unified feedback form for Privacy Pro (#3058) Fix state restoration after app termination (#3127) Bump Submodules/privacy-reference-tests from `afb4f61` to `6133e7d` (#3148) Bump version to 1.104.0 (250) Set marketing version to 1.104.0 Update embedded files Freemium PIR - Add Desktop RMF Attribute (#3146) Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145) Add missing secrets to publish_dmg_release.yml

# By Dax the Duck (9) and others # Via GitHub (6) and Dominik Kapusta (2) * main: (44 commits) Allow using a production subscription with staging VPN environment (#3109) Add error pixels for Subscription keychain access errors (#3147) onboarding dax dialogs (#3149) Logging refactoring phase #2 (#3154) Move WireGuard dependency to VPN extensions (#3144) Unified feedback form for Privacy Pro (#3058) Fix state restoration after app termination (#3127) Bump Submodules/privacy-reference-tests from `afb4f61` to `6133e7d` (#3148) Bump version to 1.104.0 (250) Set marketing version to 1.104.0 Update embedded files Freemium PIR - Add Desktop RMF Attribute (#3146) Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145) Add missing secrets to publish_dmg_release.yml Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145) Fix address bar queries when doing math expressions (#3130) Bump version to 1.103.0 (249) Bump version to 1.103.0 (248) Resolving automatic update edge cases (#3142) PIR Time-Based Pixel: 24 Opt-Out Request Success Rate (#2942) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # LocalPackages/DataBrokerProtection/Package.swift # LocalPackages/NetworkProtectionMac/Package.swift # LocalPackages/SubscriptionUI/Package.swift

ayoy added 3 commits August 25, 2024 22:13

Replace asana-extract-task-id GHA action with fastlane plugin action

610f688

Use proper output name

d55b916

Use tagged plugin

ce0faa1

ayoy commented Aug 25, 2024

View reviewed changes

ayoy requested a review from alessandroboron August 25, 2024 21:25

ayoy assigned alessandroboron Aug 25, 2024

ayoy added the merge on approve label Aug 25, 2024

alessandroboron reviewed Aug 26, 2024

View reviewed changes

alessandroboron approved these changes Aug 26, 2024

View reviewed changes

alessandroboron merged commit 081dfea into main Aug 26, 2024
22 of 23 checks passed

alessandroboron deleted the dominik/fastlane-plugin branch August 26, 2024 04:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate asana-extract-task-id GHA action to a fastlane plugin #3145

Migrate asana-extract-task-id GHA action to a fastlane plugin #3145

ayoy commented Aug 25, 2024

ayoy Aug 25, 2024

ayoy Aug 25, 2024

ayoy Aug 25, 2024

alessandroboron Aug 26, 2024

ayoy Aug 26, 2024

alessandroboron left a comment

		@@ -2,3 +2,6 @@ source 'https://rubygems.org'

		gem 'fastlane', '2.222.0'

Migrate asana-extract-task-id GHA action to a fastlane plugin #3145

Migrate asana-extract-task-id GHA action to a fastlane plugin #3145

Conversation

ayoy commented Aug 25, 2024

Internal references:

ayoy Aug 25, 2024

Choose a reason for hiding this comment

ayoy Aug 25, 2024

Choose a reason for hiding this comment

ayoy Aug 25, 2024

Choose a reason for hiding this comment

alessandroboron Aug 26, 2024

Choose a reason for hiding this comment

ayoy Aug 26, 2024

Choose a reason for hiding this comment

alessandroboron left a comment

Choose a reason for hiding this comment