Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving automatic update edge cases #3142

Merged
merged 17 commits into from
Aug 23, 2024
Merged

Resolving automatic update edge cases #3142

merged 17 commits into from
Aug 23, 2024

Conversation

tomasstrba
Copy link
Contributor

@tomasstrba tomasstrba commented Aug 23, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1148564399326804/1208127166369788/f
https://app.asana.com/0/1148564399326804/1208127166369786/f
CC:

Description:
PR resolves two edge cases related to automatic updates:

  • Presenting the available update after the update cycle finishes (instead of the update file download completion)
  • Activation of the manual update flow in case the current binary owner is different user

Steps to test this PR:

Preparation:
Download a testing build from https://staticcdn.duckduckgo.com/macos-desktop-browser/testing/duckduckgo-1.100.0.230.dmg

A) Test the edge case scenarios

Test triggering the update immediately after it is loaded.

  1. Install the testing build with a lower build number
  2. Run the app
  3. Navigate to Settings -> About
  4. Click on "Check for updates"
  5. Click on "Restart to Update" immediately after the update is loaded
  6. Make sure the new version is installed when the app is restarted

Test running an update with a different binary owner

  1. Install the testing build with a lower build number. (Don't run it)
  2. Create a new user on your macOS machine
  3. Log in as new user
  4. Run the app
  5. Navigate to Settings -> About
  6. Click on "Check for updates"
  7. Click on "Restart to Update" after the update is loaded
  8. Make sure the original Sparkle update flow is presented and you can finish the update successfully by providing credentials

B) Test regular update scenarios
Test main update scenarios
Execute following test:

  1. Install the testing build with a lower number
  2. Run the app
  3. Navigate to Settings -> About
  4. Click on "Check for updates"
  5. Click on "Restart to Update" immediately after the update is loaded
    in multiple update scenarios:
  • Automatic updates selected
  • Manual updates selected

Test the latest build

  1. While having the latest build from previous test installed, make sure the About page and Release Notes page communicate a correct state to user

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@tomasstrba tomasstrba requested a review from ayoy August 23, 2024 12:27
ayoy
ayoy approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the test build worked flawlessly every time for me, also with a multi-user setup. The code make sense too :) thanks @tomasstrba 👏

@tomasstrba tomasstrba changed the base branch from main to release/1.103.0 August 23, 2024 13:57
@tomasstrba tomasstrba merged commit c165e74 into release/1.103.0 Aug 23, 2024
23 checks passed
@tomasstrba tomasstrba deleted the tom/update-edge-case-fixes branch August 23, 2024 14:30
samsymons added a commit that referenced this pull request Aug 25, 2024
@samsymons
Merge branch 'main' into sam/allow-using-staging-vpn-with-prod-subscr…
d546672 
…iption

* main: (25 commits)
  Bump version to 1.103.0 (249)
  Bump version to 1.103.0 (248)
  Resolving automatic update edge cases (#3142)
  PIR Time-Based Pixel: 24 Opt-Out Request Success Rate (#2942)
  Freemium Local Package and Freemium State Implementation (#3118)
  Bump rexml from 3.3.3 to 3.3.6 (#3141)
  Filter out inaccessible tasks from release (#3133)
  Bump rexml from 3.2.9 to 3.3.3 (#3139)
  Bump version to 1.103.0 (247)
  Specify secrets for pr.yml where called from another workflow (#3137)
  Fix secrets usage in CI workflows (#3134)
  Adding info about how we improve our products to the README.md (#3135)
  Add Freemium PIR Feature Flag (#3129)
  Release notes page loading fix + Adding close button to the upgrade notification (#3094)
  App Configuration app group (#3132)
  Use code signing in CI tests workflows (#3125)
  'track' rephrased to 'anonymously track' (#3121)
  Additional PIR opt out confirmation pixels (#3119)
  Logging refactoring #1 Subscription and Content Blocking (#3091)
  Update RemoteMessagingDebugMenu to work on a private-queue context (#3120)
  ...
samsymons added a commit that referenced this pull request Aug 29, 2024
@samsymons
Merge branch 'main' into diego/domain-exclusion-improvements
b370a39 
# By Dax the Duck (9) and others
# Via GitHub (6) and Dominik Kapusta (2)
* main: (44 commits)
  Allow using a production subscription with staging VPN environment (#3109)
  Add error pixels for Subscription keychain access errors (#3147)
  onboarding dax dialogs (#3149)
  Logging refactoring phase #2 (#3154)
  Move WireGuard dependency to VPN extensions (#3144)
  Unified feedback form for Privacy Pro (#3058)
  Fix state restoration after app termination (#3127)
  Bump Submodules/privacy-reference-tests from `afb4f61` to `6133e7d` (#3148)
  Bump version to 1.104.0 (250)
  Set marketing version to 1.104.0
  Update embedded files
  Freemium PIR - Add Desktop RMF Attribute (#3146)
  Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145)
  Add missing secrets to publish_dmg_release.yml
  Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145)
  Fix address bar queries when doing math expressions (#3130)
  Bump version to 1.103.0 (249)
  Bump version to 1.103.0 (248)
  Resolving automatic update edge cases (#3142)
  PIR Time-Based Pixel: 24 Opt-Out Request Success Rate (#2942)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	LocalPackages/DataBrokerProtection/Package.swift
#	LocalPackages/NetworkProtectionMac/Package.swift
#	LocalPackages/SubscriptionUI/Package.swift
quanganhdo added a commit that referenced this pull request Sep 9, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
5c83056 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Sep 16, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
db2d967 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Sep 25, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
f5b745a 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Oct 7, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
6d48c1a 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Oct 10, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
414624d 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Oct 16, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
2b0c6fd 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Oct 17, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
e3b4b08 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Oct 18, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
574ab13 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Oct 23, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
1754af0 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Oct 24, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
432a82a 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Oct 24, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
b21c57d 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Oct 25, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
92cf225 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
quanganhdo added a commit that referenced this pull request Oct 29, 2024
@quanganhdo
Revert "Resolving automatic update edge cases (#3142)"
eb9eb44 
This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayoy ayoy ayoy approved these changes

Assignees

@tomasstrba tomasstrba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasstrba @ayoy