Multiple Tabs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overflow tab states. Tab item designed changed - contains gradient fade under the cancel button
|
Cannot respond to animation comment directly, so I'm responding here:
I suggest to switch to Lottie when we have more animations. The current animation is just 24 x 24 points image and I initialised the images statically, so they are loaded from the disk just once. |
|
Sure, just something for consideration later. |
brindy
reviewed
Sep 8, 2020
| @@ -1,6 +1,10 @@ | |||
|
|
|||
| disabled_rules: | |||
| - trailing_whitespace | |||
There was a problem hiding this comment.
I think should standardise across platforms - the previous rules were already established in iOS and the safari extension weren't they?
brindy
approved these changes
Sep 8, 2020
|
Thanks a lot Brindy! :) |
1 task
mallexxx
added a commit
that referenced
this pull request
Feb 21, 2023
https://app.asana.com/0/0/1203487090719125/f --------- Co-authored-by: Dominik Kapusta <dkapusta@duckduckgo.com>
Merged
samsymons
added a commit
that referenced
this pull request
May 23, 2023
Task/Issue URL: https://app.asana.com/0/0/1203279827923530/f Tech Design URL: CC: Description: This PR sets the macOS repo up for NetP work in the following ways: • Two new configurations have been added, NetworkProtection_Debug and NetworkProtection_Release, with their own bundle IDs • A new app icon has been added to both of them, to differentiate these builds from others • The product name has been set to DuckDuckGo Network Protection • The Network Extension entitlement has been added to the new configurations • Sparkle updates have been disabled. I am tracking this with a TODO (NetP): comment, but am open to a better way to keep track of changes that we need to undo before merging this into the upstream repo Note, this change does not yet add a new target for the VPN extension. I plan to keep that in a separate PR to avoid this one getting too large.
samsymons
pushed a commit
that referenced
this pull request
May 23, 2023
Task/Issue URL: https://app.asana.com/0/0/1204317674785106/f * Adds options to simulate tunnel and controller errors for testing * Adds a missing #if
1 task
1 task
aataraxiaa
added a commit
that referenced
this pull request
Aug 13, 2024
Task/Issue URL: https://app.asana.com/0/1206488453854252/1207802624568506/f **Description**: The PIR v3 migration can fail at three points: 1. Orphaned Record Cleanup 2. Table Recreation 3. Final Foreign Key Violation Check Currently, we throw an explicit error for #3, which is observable via Pixels. We should also throw explicit errors for #1 and #2. This PR adds these new errors.
federicocappelli
added a commit
that referenced
this pull request
Aug 20, 2024
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206750146033742/f Tech Design URL: https://app.asana.com/0/1200194497630846/1206777133329590/f **Description**: Step 1 of the Logging refactoring Subscription Content Blocking User Scripts SecureVault History Remote messages General (removed and create local UserDefaultCache logger)
samsymons
added a commit
that referenced
this pull request
Aug 25, 2024
…iption * main: (25 commits) Bump version to 1.103.0 (249) Bump version to 1.103.0 (248) Resolving automatic update edge cases (#3142) PIR Time-Based Pixel: 24 Opt-Out Request Success Rate (#2942) Freemium Local Package and Freemium State Implementation (#3118) Bump rexml from 3.3.3 to 3.3.6 (#3141) Filter out inaccessible tasks from release (#3133) Bump rexml from 3.2.9 to 3.3.3 (#3139) Bump version to 1.103.0 (247) Specify secrets for pr.yml where called from another workflow (#3137) Fix secrets usage in CI workflows (#3134) Adding info about how we improve our products to the README.md (#3135) Add Freemium PIR Feature Flag (#3129) Release notes page loading fix + Adding close button to the upgrade notification (#3094) App Configuration app group (#3132) Use code signing in CI tests workflows (#3125) 'track' rephrased to 'anonymously track' (#3121) Additional PIR opt out confirmation pixels (#3119) Logging refactoring #1 Subscription and Content Blocking (#3091) Update RemoteMessagingDebugMenu to work on a private-queue context (#3120) ...
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1178859670483587/f
Spec URL: https://app.asana.com/0/0/1186639470464985/f
CC:
Description:
Please see -> Spec URL
What to test in this PR:
Tab bar:
Tab Item:
Switching WebViews when selecting various tabs