Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor automatic update flow to use custom Sparkle user driver #3274

Merged
merged 65 commits into from
Oct 31, 2024

Commits on Oct 29, 2024

  1. Display Fire window downloads per Fire Window (#3250)

    Task/Issue URL:
    https://app.asana.com/0/1199230911884351/1207052331808912/f
    
    **Description**:
    - Separate downloads from Fire window and Regular windows
    
    **Steps to test this PR**:
    1. Start a download in a regular window
    2. Open a Fire Window, validate its downloads list is empty
    3. Start a download in the Fire Window; Validate the download stays in
    the list after it‘s completed.
    4. Close the Fire Window with active downloads; Validate the alert is
    displayed (with "this file" or "these files" for 1 or many files
    downloaded)
    5. Close the Fire Window, validate the downloads aren‘t displayed in the
    Regular window
    
    <!--
    Tagging instructions
    If this PR isn't ready to be merged for whatever reason it should be
    marked with the `DO NOT MERGE` label (particularly if it's a draft)
    If it's pending Product Review/PFR, please add the `Pending Product
    Review` label.
    
    If at any point it isn't actively being worked on/ready for
    review/otherwise moving forward (besides the above PR/PFR exception)
    strongly consider closing it (or not opening it in the first place). If
    you decide not to close it, make sure it's labelled to make it clear the
    PRs state and comment with more information.
    -->
    
    **Definition of Done**:
    
    * [ ] Does this PR satisfy our [Definition of
    Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?
    
    ---
    [Pull Request Review
    Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)
    [Software Engineering
    Expectations](https://app.asana.com/0/59792373528535/199064865822552)
    [Technical Design
    Template](https://app.asana.com/0/59792373528535/184709971311943)
    [Pull Request
    Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
    
    ---------
    
    Co-authored-by: Juan Manuel Pereira <juanmanuel.pereira1@gmail.com>
    2 people authored and quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f384c27 View commit details
    Browse the repository at this point in the history
  2. fix grey space and copy (#3432)

    Task/Issue URL:
    https://app.asana.com/0/1176956903599313/1208592739186184/f
    
    **Description**: Avoids grey space between DaxDialog and webView
    content, fix copy for surprise suggestion
    SabrinaTardio authored and quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3ae0e16 View commit details
    Browse the repository at this point in the history
  3. Revert "Resolving automatic update edge cases (#3142)"

    This reverts commit c165e74.
    
    # Conflicts:
    #	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
    #	DuckDuckGo/Updates/UpdateController.swift
    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    eb9eb44 View commit details
    Browse the repository at this point in the history
  4. UpdateUserDriver draft

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    16c8971 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0b90f6b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ee244be View commit details
    Browse the repository at this point in the history
  7. Show update progress

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    91cf329 View commit details
    Browse the repository at this point in the history
  8. Add manual restart

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8d69203 View commit details
    Browse the repository at this point in the history
  9. Rename delegate methods

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    af2fd57 View commit details
    Browse the repository at this point in the history
  10. Remove AppRestarter

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7fa88b3 View commit details
    Browse the repository at this point in the history
  11. Fix updateCycleDone state

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    100a367 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ea6abac View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0b7b168 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    18c53f0 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3c1d134 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    3509d82 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    d917782 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    5a98741 View commit details
    Browse the repository at this point in the history
  19. Refactor updateProgress

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e0cea62 View commit details
    Browse the repository at this point in the history
  20. Minor refactoring

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2d8f569 View commit details
    Browse the repository at this point in the history
  21. Reintroduce cached result

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2cf2ae3 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    b8fd0a4 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    b6bcdf5 View commit details
    Browse the repository at this point in the history
  24. Fix release note tab state

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8c27679 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    72f395b View commit details
    Browse the repository at this point in the history
  26. Remove unnecessary code

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c949cd5 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    926874e View commit details
    Browse the repository at this point in the history
  28. Rename isNewVersionAvailable to hasPendingUpdate and fix edge case wh…

    …ere UI stuck loading when switching between browser update modes
    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e5936b7 View commit details
    Browse the repository at this point in the history
  29. Fix stuck hasPendingStatus

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    aac36c0 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    5fda6dc View commit details
    Browse the repository at this point in the history
  31. Simplify user driver

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    855e2d8 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    a0dbbad View commit details
    Browse the repository at this point in the history
  33. Add setNeedsDisplay

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3b23423 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    5c50aa1 View commit details
    Browse the repository at this point in the history
  35. Check for update when release note / about page is loaded and when it…

    …'s due based on SULastCheckTime
    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b8dee18 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    b1a5a13 View commit details
    Browse the repository at this point in the history
  37. Add DEBUG check

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e2ec0fd View commit details
    Browse the repository at this point in the history
  38. Avoid overlapping popup

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    63d03b3 View commit details
    Browse the repository at this point in the history
  39. Code cleanup

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1e47060 View commit details
    Browse the repository at this point in the history
  40. Update copy

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b803114 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    85bac5f View commit details
    Browse the repository at this point in the history
  42. Revert "Increase build number (to be reverted)" and update appcast2 U…

    …RL (to be reverted)
    
    This reverts commit e1deee3.
    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9ddd883 View commit details
    Browse the repository at this point in the history
  43. Oops, wrong URL

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3ffbeea View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    5e4b840 View commit details
    Browse the repository at this point in the history
  45. Fix swiftlint

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0c7f2e6 View commit details
    Browse the repository at this point in the history
  46. Add missing SPARKLE checks

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8a89636 View commit details
    Browse the repository at this point in the history
  47. Design improvements to automatic update flow (#3344)

    Task/Issue URL:
    https://app.asana.com/0/1201037661562251/1208183525704010/f
    Tech Design URL:
    CC:
    Figma:
    https://www.figma.com/design/vDBpSFDzW0eN7nwpS95gju/macOS-update-process?node-id=2359-52971&t=KnvIdm2f7PRjNwfK-4
    
    **Description**:
    
    **Steps to test this PR**:
    1. Change the appcast URL to an invalid URL to test the error state
    2. Play with different update options to see if update works
    
    <!--
    Tagging instructions
    If this PR isn't ready to be merged for whatever reason it should be
    marked with the `DO NOT MERGE` label (particularly if it's a draft)
    If it's pending Product Review/PFR, please add the `Pending Product
    Review` label.
    
    If at any point it isn't actively being worked on/ready for
    review/otherwise moving forward (besides the above PR/PFR exception)
    strongly consider closing it (or not opening it in the first place). If
    you decide not to close it, make sure it's labelled to make it clear the
    PRs state and comment with more information.
    -->
    
    **Definition of Done**:
    
    * [ ] Does this PR satisfy our [Definition of
    Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?
    
    ---
    ###### Internal references:
    [Pull Request Review
    Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)
    [Software Engineering
    Expectations](https://app.asana.com/0/59792373528535/199064865822552)
    [Technical Design
    Template](https://app.asana.com/0/59792373528535/184709971311943)
    [Pull Request
    Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ca19821 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    7fe501a View commit details
    Browse the repository at this point in the history
  49. Show latest update info

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c9563d2 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    91a32e8 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    e3b2677 View commit details
    Browse the repository at this point in the history
  52. Fix wrong status

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c22ab35 View commit details
    Browse the repository at this point in the history
  53. Update BSK

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    254662f View commit details
    Browse the repository at this point in the history
  54. Reverted botched rebase

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    5e71747 View commit details
    Browse the repository at this point in the history
  55. Fix indentation

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    810f47f View commit details
    Browse the repository at this point in the history
  56. Update icons & copy (#3461)

    Task/Issue URL:
    https://app.asana.com/0/414235014887631/1208183525704010/f
    Tech Design URL:
    CC:
    
    **Description**:
    
    Addresses Ship Review comments.
    
    **Steps to test this PR**:
    1. Just copy & icon updates so this should be good if CI passes.
    
    <!--
    Tagging instructions
    If this PR isn't ready to be merged for whatever reason it should be
    marked with the `DO NOT MERGE` label (particularly if it's a draft)
    If it's pending Product Review/PFR, please add the `Pending Product
    Review` label.
    
    If at any point it isn't actively being worked on/ready for
    review/otherwise moving forward (besides the above PR/PFR exception)
    strongly consider closing it (or not opening it in the first place). If
    you decide not to close it, make sure it's labelled to make it clear the
    PRs state and comment with more information.
    -->
    
    **Definition of Done**:
    
    * [ ] Does this PR satisfy our [Definition of
    Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?
    
    ---
    ###### Internal references:
    [Pull Request Review
    Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)
    [Software Engineering
    Expectations](https://app.asana.com/0/59792373528535/199064865822552)
    [Technical Design
    Template](https://app.asana.com/0/59792373528535/184709971311943)
    [Pull Request
    Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b650882 View commit details
    Browse the repository at this point in the history
  57. Update BSK

    quanganhdo committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    fcfef66 View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    ded664d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    c7f6dd5 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Update BSK

    quanganhdo committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0867d18 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into anh/refactor/sparkle-user-driver

    # Conflicts:
    #	DuckDuckGo.xcodeproj/project.pbxproj
    #	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
    quanganhdo committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    493cbf9 View commit details
    Browse the repository at this point in the history
  3. Update BSK

    quanganhdo committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4f9d067 View commit details
    Browse the repository at this point in the history
  4. Update BSK

    quanganhdo committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4a11de7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a089e4b View commit details
    Browse the repository at this point in the history
  6. Merge branch 'main' into anh/refactor/sparkle-user-driver

    # Conflicts:
    #	DuckDuckGo.xcodeproj/project.pbxproj
    #	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
    #	LocalPackages/DataBrokerProtection/Package.swift
    #	LocalPackages/NetworkProtectionMac/Package.swift
    #	LocalPackages/SubscriptionUI/Package.swift
    quanganhdo committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    66e236c View commit details
    Browse the repository at this point in the history