-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor automatic update flow to use custom Sparkle user driver #3274
Commits on Oct 29, 2024
-
Display Fire window downloads per Fire Window (#3250)
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207052331808912/f **Description**: - Separate downloads from Fire window and Regular windows **Steps to test this PR**: 1. Start a download in a regular window 2. Open a Fire Window, validate its downloads list is empty 3. Start a download in the Fire Window; Validate the download stays in the list after it‘s completed. 4. Close the Fire Window with active downloads; Validate the alert is displayed (with "this file" or "these files" for 1 or many files downloaded) 5. Close the Fire Window, validate the downloads aren‘t displayed in the Regular window <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f) --------- Co-authored-by: Juan Manuel Pereira <juanmanuel.pereira1@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f384c27 - Browse repository at this point
Copy the full SHA f384c27View commit details -
fix grey space and copy (#3432)
Task/Issue URL: https://app.asana.com/0/1176956903599313/1208592739186184/f **Description**: Avoids grey space between DaxDialog and webView content, fix copy for surprise suggestion
Configuration menu - View commit details
-
Copy full SHA for 3ae0e16 - Browse repository at this point
Copy the full SHA 3ae0e16View commit details -
Revert "Resolving automatic update edge cases (#3142)"
This reverts commit c165e74. # Conflicts: # DuckDuckGo/Updates/BinaryOwnershipChecker.swift # DuckDuckGo/Updates/UpdateController.swift
Configuration menu - View commit details
-
Copy full SHA for eb9eb44 - Browse repository at this point
Copy the full SHA eb9eb44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16c8971 - Browse repository at this point
Copy the full SHA 16c8971View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b90f6b - Browse repository at this point
Copy the full SHA 0b90f6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee244be - Browse repository at this point
Copy the full SHA ee244beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91cf329 - Browse repository at this point
Copy the full SHA 91cf329View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d69203 - Browse repository at this point
Copy the full SHA 8d69203View commit details -
Configuration menu - View commit details
-
Copy full SHA for af2fd57 - Browse repository at this point
Copy the full SHA af2fd57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fa88b3 - Browse repository at this point
Copy the full SHA 7fa88b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 100a367 - Browse repository at this point
Copy the full SHA 100a367View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea6abac - Browse repository at this point
Copy the full SHA ea6abacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b7b168 - Browse repository at this point
Copy the full SHA 0b7b168View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18c53f0 - Browse repository at this point
Copy the full SHA 18c53f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c1d134 - Browse repository at this point
Copy the full SHA 3c1d134View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3509d82 - Browse repository at this point
Copy the full SHA 3509d82View commit details -
Configuration menu - View commit details
-
Copy full SHA for d917782 - Browse repository at this point
Copy the full SHA d917782View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a98741 - Browse repository at this point
Copy the full SHA 5a98741View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0cea62 - Browse repository at this point
Copy the full SHA e0cea62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d8f569 - Browse repository at this point
Copy the full SHA 2d8f569View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cf2ae3 - Browse repository at this point
Copy the full SHA 2cf2ae3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8fd0a4 - Browse repository at this point
Copy the full SHA b8fd0a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6bcdf5 - Browse repository at this point
Copy the full SHA b6bcdf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c27679 - Browse repository at this point
Copy the full SHA 8c27679View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72f395b - Browse repository at this point
Copy the full SHA 72f395bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c949cd5 - Browse repository at this point
Copy the full SHA c949cd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 926874e - Browse repository at this point
Copy the full SHA 926874eView commit details -
Rename isNewVersionAvailable to hasPendingUpdate and fix edge case wh…
…ere UI stuck loading when switching between browser update modes
Configuration menu - View commit details
-
Copy full SHA for e5936b7 - Browse repository at this point
Copy the full SHA e5936b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for aac36c0 - Browse repository at this point
Copy the full SHA aac36c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fda6dc - Browse repository at this point
Copy the full SHA 5fda6dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 855e2d8 - Browse repository at this point
Copy the full SHA 855e2d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0dbbad - Browse repository at this point
Copy the full SHA a0dbbadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b23423 - Browse repository at this point
Copy the full SHA 3b23423View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c50aa1 - Browse repository at this point
Copy the full SHA 5c50aa1View commit details -
Check for update when release note / about page is loaded and when it…
…'s due based on SULastCheckTime
Configuration menu - View commit details
-
Copy full SHA for b8dee18 - Browse repository at this point
Copy the full SHA b8dee18View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1a5a13 - Browse repository at this point
Copy the full SHA b1a5a13View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2ec0fd - Browse repository at this point
Copy the full SHA e2ec0fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63d03b3 - Browse repository at this point
Copy the full SHA 63d03b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e47060 - Browse repository at this point
Copy the full SHA 1e47060View commit details -
Configuration menu - View commit details
-
Copy full SHA for b803114 - Browse repository at this point
Copy the full SHA b803114View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85bac5f - Browse repository at this point
Copy the full SHA 85bac5fView commit details -
Revert "Increase build number (to be reverted)" and update appcast2 U…
…RL (to be reverted) This reverts commit e1deee3.
Configuration menu - View commit details
-
Copy full SHA for 9ddd883 - Browse repository at this point
Copy the full SHA 9ddd883View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ffbeea - Browse repository at this point
Copy the full SHA 3ffbeeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e4b840 - Browse repository at this point
Copy the full SHA 5e4b840View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c7f2e6 - Browse repository at this point
Copy the full SHA 0c7f2e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a89636 - Browse repository at this point
Copy the full SHA 8a89636View commit details -
Design improvements to automatic update flow (#3344)
Task/Issue URL: https://app.asana.com/0/1201037661562251/1208183525704010/f Tech Design URL: CC: Figma: https://www.figma.com/design/vDBpSFDzW0eN7nwpS95gju/macOS-update-process?node-id=2359-52971&t=KnvIdm2f7PRjNwfK-4 **Description**: **Steps to test this PR**: 1. Change the appcast URL to an invalid URL to test the error state 2. Play with different update options to see if update works <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Configuration menu - View commit details
-
Copy full SHA for ca19821 - Browse repository at this point
Copy the full SHA ca19821View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fe501a - Browse repository at this point
Copy the full SHA 7fe501aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9563d2 - Browse repository at this point
Copy the full SHA c9563d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91a32e8 - Browse repository at this point
Copy the full SHA 91a32e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3b2677 - Browse repository at this point
Copy the full SHA e3b2677View commit details -
Configuration menu - View commit details
-
Copy full SHA for c22ab35 - Browse repository at this point
Copy the full SHA c22ab35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 254662f - Browse repository at this point
Copy the full SHA 254662fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e71747 - Browse repository at this point
Copy the full SHA 5e71747View commit details -
Configuration menu - View commit details
-
Copy full SHA for 810f47f - Browse repository at this point
Copy the full SHA 810f47fView commit details -
Task/Issue URL: https://app.asana.com/0/414235014887631/1208183525704010/f Tech Design URL: CC: **Description**: Addresses Ship Review comments. **Steps to test this PR**: 1. Just copy & icon updates so this should be good if CI passes. <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Configuration menu - View commit details
-
Copy full SHA for b650882 - Browse repository at this point
Copy the full SHA b650882View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcfef66 - Browse repository at this point
Copy the full SHA fcfef66View commit details -
Configuration menu - View commit details
-
Copy full SHA for ded664d - Browse repository at this point
Copy the full SHA ded664dView commit details
Commits on Oct 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c7f6dd5 - Browse repository at this point
Copy the full SHA c7f6dd5View commit details
Commits on Oct 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0867d18 - Browse repository at this point
Copy the full SHA 0867d18View commit details -
Merge branch 'main' into anh/refactor/sparkle-user-driver
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Configuration menu - View commit details
-
Copy full SHA for 493cbf9 - Browse repository at this point
Copy the full SHA 493cbf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f9d067 - Browse repository at this point
Copy the full SHA 4f9d067View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a11de7 - Browse repository at this point
Copy the full SHA 4a11de7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a089e4b - Browse repository at this point
Copy the full SHA a089e4bView commit details -
Merge branch 'main' into anh/refactor/sparkle-user-driver
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # LocalPackages/DataBrokerProtection/Package.swift # LocalPackages/NetworkProtectionMac/Package.swift # LocalPackages/SubscriptionUI/Package.swift
Configuration menu - View commit details
-
Copy full SHA for 66e236c - Browse repository at this point
Copy the full SHA 66e236cView commit details