Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL encoding error loop #536

Closed
wants to merge 1 commit into from
Closed

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Apr 13, 2022

Task/Issue URL: https://app.asana.com/0/1199178362774117/1202118733626429/f
Tech Design URL:
CC:

Description:

If an error is detected call stop loading explicitly to avoid getting into weird URL loading loops.

Steps to test this PR:

  1. In the above task click on the link with the name "bad privacy triage link" - it won't load but will show an asana popover. Click on the link in the popover to open that in a new tab.
  2. The URL will fail to load and show the error screen.

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@mallexxx mallexxx self-assigned this Apr 15, 2022
Copy link
Collaborator

@mallexxx mallexxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the fix doesn‘t work for me: the page continues endless loading loop blinking with the Progress Bar
There's also a DDOS side effect: the brows
er hangs if I try to select the Address Bar while it tries to process the test request or when I open a New Tab (see screenshots)

BTW, this loading problem is fixed in #516

Screenshot 2022-04-15 at 16 40 54
Screenshot 2022-04-15 at 16 45 09

@mallexxx mallexxx assigned brindy and unassigned mallexxx Apr 15, 2022
@brindy
Copy link
Contributor Author

brindy commented Apr 19, 2022

Will close this one since you fixed it already. :)

@brindy brindy closed this Apr 19, 2022
@brindy brindy deleted the brindy/fix-bad-url-handling branch June 6, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants