Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable download reload on page tab reactivation/session restoration #516

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Disable download reload on page tab reactivation/session restoration #516

merged 4 commits into from
Apr 21, 2022

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Apr 8, 2022

Task/Issue URL: https://app.asana.com/0/1199237043630360/1201176142859594
Tech Design URL:
CC:

Description:

  • Disables page reload when loading failed with error non-related to connectivity
  • Disables reload of Tab started download on session restoration

Steps to test this PR:

  1. Open Tab launching download (e.g. open an image https://app.asana.com/0/1196651294178074/1201123852249428/f and copy download link, open it in a new tab as it will auto-close if opened using the link)
  2. After download has started activate another tab and reactivate the downloaded tab
  3. Validate download isn't started again
  4. Relaunch browser, validate download isn't started on the Tab restoration
  5. Turn off wifi, validate navigation error is shown and Tab is tried to be reloaded on reactivation
  6. Navigate to non-existent URL, validate Tab isn't reloaded on reactivation

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@brindy
Copy link
Contributor

brindy commented Apr 14, 2022

@mallexxx is this still valid? I followed the steps using the prod app and they all passed

@mallexxx
Copy link
Collaborator Author

@brindy yes, valid, on actual build download is triggered every time the Tab is activated or on Tab Restoration
Page having an error (like invalid domain) reload is triggered every time the Tab is activated

@mallexxx mallexxx assigned brindy and unassigned mallexxx Apr 14, 2022
brindy
brindy approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brindy brindy assigned mallexxx and unassigned brindy Apr 20, 2022
@mallexxx mallexxx merged commit 4c42210 into develop Apr 21, 2022
@mallexxx mallexxx deleted the alex/fix-double-download branch April 21, 2022 11:25
samsymons added a commit that referenced this pull request Apr 27, 2022
@samsymons
Merge branch 'develop' into sam/password-generation
a1cb477 
# By Alexey Martemyanov (3) and others
# Via GitHub
* develop:
  Lazy load background tabs at app startup (#553)
  Update the Fireproof checkmark in the Save Credentials view controller (#555)
  Support config v2 (#528)
  Fullscreen video fixing (#541)
  Add data import failure pixels (#552)
  Update BSK to fix autofill on Catalina (#551)
  fix contrast bug on Catalina / Big Sur (#546)
  Disable download reload on page tab reactivation/session restoration (#516)
  Add "New Window" item to App Dock menu (#544)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

@tomasstrba tomasstrba Awaiting requested review from tomasstrba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @brindy