Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1202158855860055/f
Tech Design URL:
CC: @brindy
Description:
This PR adds a new pixel which reports the import source, import type, and error message when data import fails.
The format and parameters of this pixel are found here.
The pixel from this PR will be used to drill down into where the importer is failing and why next week, and translate into some fixes. One thing we're missing is the actual versions of the files we're reading from, which will be added in a follow-up later.
Steps to test this PR:
First: turn on pixel logging in
Logging.swift
.Next: It's hard to set up the import failure conditions needed, so I recommend picking one of the import classes and adding a hardcoded failure to it. This won't help with testing whether the actual importer classes themselves are returning the right error at the right time, but I haven't modified those here and plan to expand their test suites in a PR to ensure that all cases are covered next week.
You can use
ChromiumDataImporter.swift
and add the following line to the top of theimportData
function (of course, please tweak the failure type to test that the pixel is accurate):Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM