Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BSK to fix autofill on Catalina #551

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

GioSensation
Copy link
Member

Task/Issue URL: https://app.asana.com/0/1199178362774117/1202127639259814/f
Tech Design URL: NA

Description:
Fixes autofill tooltip in Catalina by disabling top autofill (uses the old in-page tooltip).

Steps to test this PR:

  1. Try using autofill in Catalina.
  2. If you can click it and it autofill, it works 🎉!

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy assigned GioSensation and unassigned brindy Apr 21, 2022
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
@GioSensation GioSensation merged commit dc2f49e into develop Apr 21, 2022
@GioSensation GioSensation deleted the ema/fix-autofill-on-catalina branch April 21, 2022 15:48
samsymons added a commit that referenced this pull request Apr 27, 2022
# By Alexey Martemyanov (3) and others
# Via GitHub
* develop:
  Lazy load background tabs at app startup (#553)
  Update the Fireproof checkmark in the Save Credentials view controller (#555)
  Support config v2 (#528)
  Fullscreen video fixing (#541)
  Add data import failure pixels (#552)
  Update BSK to fix autofill on Catalina (#551)
  fix contrast bug on Catalina / Big Sur (#546)
  Disable download reload on page tab reactivation/session restoration (#516)
  Add "New Window" item to App Dock menu (#544)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants