Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config v2 #528

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Support config v2 #528

merged 4 commits into from
Apr 22, 2022

Conversation

SlayterDev
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1200890834746050/1201683113648489/f
Tech Design URL:
CC: @tomasstrba @bwaresiak @jonathanKingston

Description:
This PR add support for privacy config v2 and updates the embedded config

Steps to test this PR:

  1. Run browser and check behavior is normal
  2. Edit the local config (and force the config manager to use the local config) to use a minSupportedVersion for a feature with a version beyond the current version (e.g. 0.22.3)
  3. That feature should appear disabled

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I smoke tested various features of the app, and then forced the PrivacyConfigurationManager to return the embedded config, and tested that toggling various features worked as expected.

@samsymons samsymons assigned SlayterDev and unassigned samsymons Apr 22, 2022
@samsymons
Copy link
Collaborator

Since @SlayterDev is out, I'm going to post in the Apple Devs channel requesting that Bartek double check these PRs (since he also had feedback) and if no issues then to have someone release BSK and merge this PR.

@samsymons samsymons assigned bwaresiak and unassigned SlayterDev Apr 22, 2022
@samsymons
Copy link
Collaborator

samsymons commented Apr 22, 2022

Note: merging develop into this branch broke the unit tests, as the macos-config file's hash no longer matched. To fix this, I've fetched the latest copy of the v2 config and included it with updated ETag and SHA.

You can check the original in this commit vs. the one I added here.

ETag was taken from here 👇
macos-config ETag

@mallexxx mallexxx assigned mallexxx and unassigned bwaresiak Apr 22, 2022
@mallexxx mallexxx merged commit 0c67d7a into develop Apr 22, 2022
@mallexxx mallexxx deleted the brad/support-config-v2 branch April 22, 2022 12:45
samsymons added a commit that referenced this pull request Apr 27, 2022
# By Alexey Martemyanov (3) and others
# Via GitHub
* develop:
  Lazy load background tabs at app startup (#553)
  Update the Fireproof checkmark in the Save Credentials view controller (#555)
  Support config v2 (#528)
  Fullscreen video fixing (#541)
  Add data import failure pixels (#552)
  Update BSK to fix autofill on Catalina (#551)
  fix contrast bug on Catalina / Big Sur (#546)
  Disable download reload on page tab reactivation/session restoration (#516)
  Add "New Window" item to App Dock menu (#544)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants