-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support config v2 #528
Support config v2 #528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I smoke tested various features of the app, and then forced the PrivacyConfigurationManager
to return the embedded config, and tested that toggling various features worked as expected.
Since @SlayterDev is out, I'm going to post in the Apple Devs channel requesting that Bartek double check these PRs (since he also had feedback) and if no issues then to have someone release BSK and merge this PR. |
Note: merging You can check the original in this commit vs. the one I added here. |
# By Alexey Martemyanov (3) and others # Via GitHub * develop: Lazy load background tabs at app startup (#553) Update the Fireproof checkmark in the Save Credentials view controller (#555) Support config v2 (#528) Fullscreen video fixing (#541) Add data import failure pixels (#552) Update BSK to fix autofill on Catalina (#551) fix contrast bug on Catalina / Big Sur (#546) Disable download reload on page tab reactivation/session restoration (#516) Add "New Window" item to App Dock menu (#544) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Task/Issue URL: https://app.asana.com/0/1200890834746050/1201683113648489/f
Tech Design URL:
CC: @tomasstrba @bwaresiak @jonathanKingston
Description:
This PR add support for privacy config v2 and updates the embedded config
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM